Skip to content

Commit bea0f9b

Browse files
committed
Add support for BackendError to backend responses (neo4j#914)
1 parent 446cfdc commit bea0f9b

File tree

4 files changed

+21
-45
lines changed

4 files changed

+21
-45
lines changed

testkit-backend/src/main/java/neo4j/org/testkit/backend/CommandProcessor.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import com.fasterxml.jackson.databind.ObjectMapper;
2424
import neo4j.org.testkit.backend.messages.TestkitModule;
2525
import neo4j.org.testkit.backend.messages.requests.TestkitRequest;
26+
import neo4j.org.testkit.backend.messages.responses.BackendError;
2627
import neo4j.org.testkit.backend.messages.responses.DriverError;
27-
import neo4j.org.testkit.backend.messages.responses.TestkitErrorResponse;
2828
import neo4j.org.testkit.backend.messages.responses.TestkitResponse;
2929

3030
import java.io.BufferedReader;
@@ -154,7 +154,7 @@ else if ( currentLine.equals( "#request end" ) )
154154
// Unknown error, interpret this as a backend error.
155155
// Report to frontend and rethrow, note that if socket been
156156
// closed the writing will throw itself...
157-
writeResponse( TestkitErrorResponse.builder().errorMessage( e.toString() ).build() );
157+
writeResponse( BackendError.builder().data( BackendError.BackendErrorBody.builder().msg( e.toString() ).build() ).build() );
158158
// This won't print if there was an IO exception since line above will rethrow
159159
e.printStackTrace();
160160
throw e;

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/NewDriver.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
import lombok.RequiredArgsConstructor;
2424
import lombok.Setter;
2525
import neo4j.org.testkit.backend.TestkitState;
26+
import neo4j.org.testkit.backend.messages.responses.BackendError;
2627
import neo4j.org.testkit.backend.messages.responses.DomainNameResolutionRequired;
2728
import neo4j.org.testkit.backend.messages.responses.Driver;
2829
import neo4j.org.testkit.backend.messages.responses.DriverError;
2930
import neo4j.org.testkit.backend.messages.responses.ResolverResolutionRequired;
30-
import neo4j.org.testkit.backend.messages.responses.TestkitErrorResponse;
3131
import neo4j.org.testkit.backend.messages.responses.TestkitResponse;
3232

3333
import java.net.URI;
@@ -67,8 +67,13 @@ public TestkitResponse process( TestkitState testkitState )
6767
data.authorizationToken.getTokens().get( "realm" ) );
6868
break;
6969
default:
70-
return TestkitErrorResponse.builder().errorMessage( "Auth scheme " + data.authorizationToken.getTokens().get( "scheme" ) + "not implemented" )
71-
.build();
70+
return BackendError.builder()
71+
.data( BackendError
72+
.BackendErrorBody.builder()
73+
.msg( "Auth scheme " + data.authorizationToken.getTokens().get( "scheme" ) +
74+
"not implemented" )
75+
.build() )
76+
.build();
7277
}
7378

7479
Config.ConfigBuilder configBuilder = Config.builder();
Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,21 @@
2525
@Setter
2626
@Getter
2727
@Builder
28-
public class TestkitBackendErrorResponse implements TestkitResponse
28+
public class BackendError implements TestkitResponse
2929
{
30+
private final BackendErrorBody data;
31+
3032
@Override
3133
public String testkitName()
3234
{
3335
return "BackendError";
3436
}
37+
38+
@Setter
39+
@Getter
40+
@Builder
41+
public static class BackendErrorBody
42+
{
43+
private String msg;
44+
}
3545
}

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/TestkitErrorResponse.java

Lines changed: 0 additions & 39 deletions
This file was deleted.

0 commit comments

Comments
 (0)