Skip to content

Commit 9e55de7

Browse files
authored
Make Config.bookmarkManager return Optional (neo4j#1292)
1 parent d339b93 commit 9e55de7

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

driver/src/main/java/org/neo4j/driver/Config.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import java.util.Collections;
3131
import java.util.List;
3232
import java.util.Objects;
33+
import java.util.Optional;
3334
import java.util.concurrent.TimeUnit;
3435
import java.util.logging.Level;
3536
import org.neo4j.driver.internal.SecuritySettings;
@@ -258,10 +259,10 @@ public String userAgent() {
258259
/**
259260
* A {@link BookmarkManager} implementation for the driver to use.
260261
*
261-
* @return bookmark implementation or {@code null}.
262+
* @return bookmark implementation
262263
*/
263-
public BookmarkManager bookmarkManager() {
264-
return bookmarkManager;
264+
public Optional<BookmarkManager> bookmarkManager() {
265+
return Optional.ofNullable(bookmarkManager);
265266
}
266267

267268
/**

driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,7 +261,11 @@ protected InternalDriver createRoutingDriver(
261261
protected InternalDriver createDriver(
262262
SecurityPlan securityPlan, SessionFactory sessionFactory, MetricsProvider metricsProvider, Config config) {
263263
return new InternalDriver(
264-
securityPlan, sessionFactory, metricsProvider, config.logging(), config.bookmarkManager());
264+
securityPlan,
265+
sessionFactory,
266+
metricsProvider,
267+
config.logging(),
268+
config.bookmarkManager().orElse(null));
265269
}
266270

267271
/**

0 commit comments

Comments
 (0)