Skip to content

Commit e8ea300

Browse files
committed
Fix some of the cordova preferences in Grunt
1 parent eb7c39a commit e8ea300

File tree

4 files changed

+15
-13
lines changed

4 files changed

+15
-13
lines changed

Gruntfile.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -406,12 +406,12 @@ module.exports = function (grunt) {
406406
}
407407
});
408408

409-
var xpath = require('xpath');
410-
var dom = require('xmldom').DOMParser;
409+
//var xpath = require('xpath');
410+
var DOMParser = require('xmldom').DOMParser;
411411
grunt.registerTask('addCordovaPreferences', function(){
412412
var cordovaConfig = appConfig.cordova + '/config.xml';
413413
var xml = grunt.file.read(cordovaConfig);
414-
var doc = new dom().parseFromString(xml);
414+
var doc = new DOMParser().parseFromString(xml);
415415

416416
var node = doc.getElementsByTagName('widget')[0];
417417

@@ -445,6 +445,12 @@ module.exports = function (grunt) {
445445
grunt.log.writeln('Adding: ' + KeyboardDisplayRequiresUserAction);
446446
node.appendChild(KeyboardDisplayRequiresUserAction);
447447

448+
var DisallowOverscroll = doc.createElement('preference');
449+
DisallowOverscroll.setAttribute('name', 'DisallowOverscroll');
450+
DisallowOverscroll.setAttribute('value', true);
451+
grunt.log.writeln('Adding: ' + DisallowOverscroll);
452+
node.appendChild(DisallowOverscroll);
453+
448454
grunt.file.write(cordovaConfig, doc);
449455
});
450456

app/scripts/app.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,18 @@ var app = angular
1717
'ngSanitize',
1818
'ngTouch',
1919
'ngMaterial'
20-
])
20+
]);
2121

2222
app.run(function ($rootScope, $location, $mdSidenav, $mdToast) {
2323

2424
var searchActive = false;
2525

2626
$rootScope.openSidenav = function() {
2727
$mdToast.hide();
28-
console.log("toggling left");
28+
console.log('toggling left');
2929
$mdSidenav('left').open()
3030
.then(function(){
31-
console.debug("toggle left is done");
31+
console.debug('toggle left is done');
3232
});
3333
};
3434

app/views/sidenav.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
<md-sidenav class="md-sidenav-left md-whiteframe-z2" md-component-id="left" md-is-locked-open="$media('gt-md')">
2-
<md-toolbar class="md-theme-indigo">
3-
<h1 class="md-toolbar-tools">Menu</h1>
4-
</md-toolbar>
52
<md-content class="md-padding">
63
<section>
74
<md-subheader>About</md-subheader>

package.json

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
"name": "yoangularchrome",
33
"version": "0.0.0",
44
"dependencies": {
5-
"grunt-bower-task": "^0.4.0",
6-
"xmldom": "^0.1.19",
7-
"xpath": "0.0.9"
85
},
96
"devDependencies": {
107
"grunt": "^0.4.1",
@@ -34,7 +31,9 @@
3431
"karma-jasmine": "^0.2.3",
3532
"karma-phantomjs-launcher": "^0.1.4",
3633
"load-grunt-tasks": "^0.4.0",
37-
"time-grunt": "^0.3.1"
34+
"time-grunt": "^0.3.1",
35+
"grunt-bower-task": "^0.4.0",
36+
"xmldom": "^0.1.19"
3837
},
3938
"engines": {
4039
"node": ">=0.10.0"

0 commit comments

Comments
 (0)