flux_table.py Linting (Bug and FIX)

[youarecode]

Specifications

• Client Version: 1.46.0
• InfluxDB Version:
• Platform:

Code sample to reproduce problem

TableList Typing is not working:

• just write (no need to execute) this in vscode, it may lead to a static linting error

bucket='MyBucket'
measurement='MyMeasurement'
field='MyField'
query=f'''
        from(bucket: "{bucket}")
        |> range(start:0)
        |> filter(fn: (r) => r["_measurement"] == "{measurement}")
        |> filter(fn: (r) => r["_field"] == "{field}")
        |> last()
'''
client=InfluxDBClient(url, token, org)
query_api=client.query_api()
result=query_api.query(query)

MyValue=result[0].records[0].get_value() if result else False
MyTimestamp=result[0].records[0].get_time()  if result else False

Expected behavior

Linting to work for:

• record field 'get_value()' or get_time()

Actual behavior

SOLUTION:

Add typing here:

# flux_table.py
class FluxTable(FluxStructure):
    def __init__(self) -> None:
        """Initialize defaults."""
        self.columns: List[FluxColumn] = []  #<<<<---- add this typing here
        self.records: List[FluxRecord] = []     #<<<<---- add this typing here

Additional info

Thank you in advance

[bednar]

@youarecode thanks for using our client.

Is this something you would be willing to help with? All PR is welcome and we will be happy to review your submission.

[youarecode]

You are probably right, but to be honest, that line of code was my first contact with influxdb,

Even for simple code I know nothing about the system. :)

[bednar]

Your code suggestion is fine and correct 👍

SOLUTION:

Add typing here:

# flux_table.py
class FluxTable(FluxStructure):
    def __init__(self) -> None:
        """Initialize defaults."""
        self.columns: List[FluxColumn] = []  #<<<<---- add this typing here
        self.records: List[FluxRecord] = []     #<<<<---- add this typing here

Once you’ve submitted the PR, I’ll review it as soon as possible. If there are any further adjustments needed, I’ll provide feedback through the GitHub PR comments.

You’re on your way to becoming one of our contributors ;)

[youarecode]

Thx you very much, I'll do it in a couple of hours

…

On Mon, Oct 7, 2024, 06:56 Jakub Bednář ***@***.***> wrote: Your code suggestion is fine and correct 👍 SOLUTION: Add typing here: # flux_table.pyclass FluxTable(FluxStructure): def __init__(self) -> None: """Initialize defaults.""" self.columns: List[FluxColumn] = [] #<<<<---- add this typing here self.records: List[FluxRecord] = [] #<<<<---- add this typing here Once you’ve submitted the PR, I’ll review it as soon as possible. If there are any further adjustments needed, I’ll provide feedback through the GitHub PR comments. You’re on your way to becoming one of our contributors ;) — Reply to this email directly, view it on GitHub <#674 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BF3NI3QXP2BWOUKLYKJH3MLZ2JLEXAVCNFSM6AAAAABPOMLN7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGQ3DCMJUGU> . You are receiving this because you were mentioned.Message ID: ***@***.***>