-
Notifications
You must be signed in to change notification settings - Fork 186
MTLS support for the Python client #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @ZPascal, thanks for using our client and your proposal.
I will be happy to review your PR... btw every PR is welcome.
How will it works together with Regards |
Hi @bednar, I would expect that the variable is None (if you did not specify a certificate) and at the end not really used inside the connection pool manager. I can also maybe implement inside the PR the full MTLS support delivered by classical shipped certs via the configuration. The framework is already there and used but not mapped to the configuration option/ initialization. :) So in the end, the user got the option to use one of both possibilities. |
@ZPascal it sounds good 👍 I will be happy to review and merge your PR ;) |
Hi @bednar, thank you for merging the PR. Could you please share with me the timeline to publish the new release version? |
@ZPascal you can use current |
@bednar Thank you for the info. I've got already a wheel file on my side to consume the change. I just wanted to know when I can replace it :) |
Uh oh!
There was an error while loading. Please reload this page.
Proposal:
We should also support mutual TLS for the InfluxDB client. The implementation could be handled as a quick win and I can prepare the corresponding functionality inside a PR. The client uses
urllib3
as a library to establish a connection to the InfluxDB and the MTLS support is already implemented inside it. Currently, there are two possible ways to implement the MTLS support inside the client:urllib3
via the**kwags
functionality (Personal favorited implementation, more adaptable)urllib3
Current behavior:
Currently, it's possible to define e.g. a Python SSL context as
**kwags
but this context is not forwarded to all calls at the end.Desired behavior:
I would expect that MTLS is also supported by the library.
Use case:
The use case is the possibility to establish an MTLS connection to the InfluxDB.
The text was updated successfully, but these errors were encountered: