InfluxDBClient.ping() method shouldn't log an error

[pbybee]

Steps to reproduce:
List the minimal actions needed to reproduce the behavior.

1. Create influxdbclient instance without influx backend running
2. Run instance.ping() method within a try:... except: block.
3. Observe ERROR logged.

Expected behavior:
Error should be raised instead of logged, or ping should simply return false is connection cannot be created.

Actual behavior:
Error is logged when connection cannot be created.
influxdb_client.client.influxdb_client| Unexpected error during /ping: <urllib3.connection.HTTPConnection object at 0x7fd486f43f50>: Failed to establish a new connection: [Errno 111]
Connection refused

Specifications:

• Client Version: influxdb-client 1.24.0
• InfluxDB Version: 1.8
• Platform: Ubuntu 18.04

[bednar]

Hi @pbybee,

thanks for using our client.

Can you share a little bit more about your usages? Is there a reason why the error can't be logged?

Regards

[pbybee]

Hi there! maybe I don't have the same design mindset. I would expect a client that I am writing into a larger piece of software to throw exceptions and let the caller deal with logging. In this specific case, I am using ping to confirm that influx is available. And if it is not, then it is not an error in my application. If ping is a check which should return true or false depending on the state of the influxdb instance, I would assume it returns false, and not log an error. Does that make sense?

[bednar]

I would assume it returns false, and not log an error. Does that make sense?

Yes, thanks for clarification.

I would like to keep possibility to log the reason of failure. I will change the log level to debug.