Skip to content

Possibility to pass custom ssl cert #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PhilippSelenium opened this issue Sep 23, 2020 · 4 comments · Fixed by #158
Closed

Possibility to pass custom ssl cert #157

PhilippSelenium opened this issue Sep 23, 2020 · 4 comments · Fixed by #158
Labels
enhancement New feature or request
Milestone

Comments

@PhilippSelenium
Copy link

Proposal:
Possibility to pass custom ssl cert like in the old API: https://github.com/influxdata/influxdb-python/blob/master/influxdb/client.py#L108

Current behavior:
Monkey patching

class _CustomConfiguration(client.influxdb_client._Configuration):
    def __init__(self):
        super().__init__()
        self.ssl_ca_cert = "custom_path"
client.influxdb_client._Configuration = _CustomConfiguration

Desired behavior:
Possibility to pass ssl cert

Alternatives considered:
Monkey patching

Use case:
Sitting behind a company proxy that requires you to use a custom CA

@bednar
Copy link
Contributor

bednar commented Sep 23, 2020

Hi @PhilippSelenium,

thanks for your proposal. I will take a look ASAP.

Regards

@bednar
Copy link
Contributor

bednar commented Sep 24, 2020

Hi @PhilippSelenium,

I've prepared PR #158.

If you would like to test it then install client via:

pip install git+https://github.com/influxdata/influxdb-client-python.git@feat/cert-configuration

Regards

@PhilippSelenium
Copy link
Author

Thanks a lot for the quick fix. Works great!

@bednar
Copy link
Contributor

bednar commented Sep 24, 2020

You are welcome.

@bednar bednar added this to the 1.11.0 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants