Skip to content

Commit d1035a1

Browse files
committed
Replace calls to __del__ with calls to close
1 parent a3e18ee commit d1035a1

19 files changed

+55
-52
lines changed

README.rst

+12-12
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,8 @@ The batching is configurable by ``write_options``\ :
345345
"""
346346
Close client
347347
"""
348-
_write_client.__del__()
349-
_client.__del__()
348+
_write_client.close()
349+
_client.close()
350350
351351
.. marker-batching-end
352352
@@ -436,7 +436,7 @@ Data are writes in an asynchronous HTTP request.
436436
async_result = write_api.write(bucket="my-bucket", record=[_point1, _point2])
437437
async_result.get()
438438
439-
client.__del__()
439+
client.close()
440440
441441
Synchronous client
442442
""""""""""""""""""
@@ -456,7 +456,7 @@ Data are writes in a synchronous HTTP request.
456456
457457
write_api.write(bucket="my-bucket", record=[_point1, _point2])
458458
459-
client.__del__()
459+
client.close()
460460
461461
Queries
462462
^^^^^^^
@@ -537,7 +537,7 @@ The API also support streaming ``FluxRecord`` via `query_stream <https://github.
537537
"""
538538
Close client
539539
"""
540-
client.__del__()
540+
client.close()
541541
542542
Pandas DataFrame
543543
""""""""""""""""
@@ -580,7 +580,7 @@ The ``client`` is able to retrieve data in `Pandas DataFrame <https://pandas.pyd
580580
"""
581581
Close client
582582
"""
583-
client.__del__()
583+
client.close()
584584
585585
Output:
586586

@@ -677,7 +677,7 @@ If you would like to import gigabytes of data then use our multiprocessing examp
677677
Write data into InfluxDB
678678
"""
679679
write_api.write(bucket="my-bucket", record=data)
680-
write_api.__del__()
680+
write_api.close()
681681
682682
"""
683683
Querying max value of CBOE Volatility Index
@@ -701,7 +701,7 @@ If you would like to import gigabytes of data then use our multiprocessing examp
701701
"""
702702
Close client
703703
"""
704-
client.__del__()
704+
client.close()
705705
706706
.. marker-writes-end
707707
@@ -734,8 +734,8 @@ Efficiency write data from IOT sensor
734734
:param write_api: WriteApi
735735
:return: nothing
736736
"""
737-
write_api.__del__()
738-
db_client.__del__()
737+
write_api.close()
738+
db_client.close()
739739
740740
741741
def sensor_temperature():
@@ -930,7 +930,7 @@ The `delete_api.py <influxdb_client/client/delete_api.py>`_ supports deletes `po
930930
"""
931931
Close client
932932
"""
933-
client.__del__()
933+
client.close()
934934
935935
.. marker-delete-end
936936
@@ -1031,7 +1031,7 @@ that is replacement for python ``datetime.datetime`` object and also you should
10311031
"""
10321032
Close client
10331033
"""
1034-
client.__del__()
1034+
client.close()
10351035
10361036
10371037
Local tests

examples/import_data_set.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ def parse_row(row: OrderedDict):
7171
Write data into InfluxDB
7272
"""
7373
write_api.write(bucket="my-bucket", record=data)
74-
write_api.__del__()
74+
write_api.close()
7575

7676
"""
7777
Querying max value of CBOE Volatility Index
@@ -95,4 +95,4 @@ def parse_row(row: OrderedDict):
9595
"""
9696
Close client
9797
"""
98-
client.__del__()
98+
client.close()

examples/import_data_set_multiprocessing.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,8 @@ def terminate(self) -> None:
6060
proc_name = self.name
6161
print()
6262
print('Writer: flushing data...')
63-
self.write_api.__del__()
64-
self.client.__del__()
63+
self.write_api.close()
64+
self.client.close()
6565
print('Writer: closed'.format(proc_name))
6666

6767

@@ -216,4 +216,4 @@ def init_counter(counter, progress, queue):
216216
"""
217217
Close client
218218
"""
219-
client.__del__()
219+
client.close()

examples/influxdb_18_example.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
print(point.to_line_protocol())
1919

2020
write_api.write(bucket=bucket, record=point)
21-
write_api.__del__()
21+
write_api.close()
2222

2323
print('*** Query Points ***')
2424

examples/ingest_dataframe_default_tags.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,4 @@
4949
"""
5050
Close client
5151
"""
52-
client.__del__()
52+
client.close()

examples/iot_sensor.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ def on_exit(db_client: InfluxDBClient, write_api: WriteApi):
2020
:param write_api: WriteApi
2121
:return: nothing
2222
"""
23-
write_api.__del__()
24-
db_client.__del__()
23+
write_api.close()
24+
db_client.close()
2525

2626

2727
def sensor_temperature():

examples/nanosecond_precision.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,4 +47,4 @@
4747
"""
4848
Close client
4949
"""
50-
client.__del__()
50+
client.close()

examples/query.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@
7575
"""
7676
Close client
7777
"""
78-
client.__del__()
78+
client.close()

examples/query_from_file.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
"""
4747
Close client
4848
"""
49-
client.__del__()
49+
client.close()
5050

5151

5252

examples/rx_playground.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@ def __init__(self) -> None:
5454
.subscribe(self._result, self._error, self._on_complete)
5555
pass
5656

57+
def close(self):
58+
self.__del__()
59+
5760
def __del__(self):
5861
if self._subject:
5962
self._subject.on_completed()
@@ -179,8 +182,8 @@ def _group_to_batch(group: GroupedObservable):
179182
print("\n== finish writing ==\n")
180183
time.sleep(5)
181184

182-
print("\n== __del__ ==\n")
183-
rxWriter.__del__()
185+
print("\n== close ==\n")
186+
rxWriter.close()
184187

185188
print("\n== finished ==\n")
186189

notebooks/stock_predictions_import_data.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def main():
6161
write_api = client.write_api(write_options=WriteOptions(batch_size=50_000, flush_interval=10_000))
6262

6363
write_api.write(bucket="my-bucket", record=data)
64-
write_api.__del__()
64+
write_api.close()
6565

6666
query = '''
6767
from(bucket:"my-bucket")
@@ -78,7 +78,7 @@ def main():
7878
"""
7979
Close client
8080
"""
81-
client.__del__()
81+
client.close()
8282
# %%
8383

8484

tests/test_QueryApiDataFrame.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def setUp(self) -> None:
2020
httpretty.reset()
2121

2222
def tearDown(self) -> None:
23-
self.client.__del__()
23+
self.client.close()
2424
httpretty.disable()
2525

2626
def test_one_table(self):
@@ -276,7 +276,7 @@ def _create_point(index) -> Point:
276276

277277
write_api = self.client.write_api(write_options=WriteOptions(batch_size=500))
278278
write_api.write(org="my-org", bucket="my-bucket", record=data, write_precision=WritePrecision.S)
279-
write_api.__del__()
279+
write_api.close()
280280

281281
query = 'from(bucket: "my-bucket")' \
282282
'|> range(start: 2020-02-19T23:30:00Z, stop: now())' \

tests/test_QueryApiStream.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def setUp(self) -> None:
1515
self.bucket = self.create_test_bucket()
1616

1717
def tearDown(self) -> None:
18-
self.write_client.__del__()
18+
self.write_client.close()
1919
super().tearDown()
2020

2121
def test_block(self):

tests/test_WriteApi.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def setUp(self) -> None:
3535
'${env.data_center}'}))
3636

3737
def tearDown(self) -> None:
38-
self.write_client.__del__()
38+
self.write_client.close()
3939
super().tearDown()
4040

4141
def test_write_line_protocol(self):
@@ -425,7 +425,7 @@ def test_check_write_permission_by_empty_data(self):
425425
self.assertEqual(401, exception.status)
426426
self.assertEqual("Unauthorized", exception.reason)
427427

428-
client.__del__()
428+
client.close()
429429

430430
def test_write_query_data_nanoseconds(self):
431431

@@ -477,7 +477,7 @@ def setUp(self) -> None:
477477
self.influxdb_client = InfluxDBClient(url=conf.host, token="my-token")
478478

479479
def tearDown(self) -> None:
480-
self.influxdb_client.__del__()
480+
self.influxdb_client.close()
481481
httpretty.disable()
482482

483483
def test_writes_synchronous_without_retry(self):
@@ -521,7 +521,7 @@ def setUp(self) -> None:
521521
'${env.data_center}'}))
522522

523523
def tearDown(self) -> None:
524-
self.write_client.__del__()
524+
self.write_client.close()
525525
super().tearDown()
526526

527527
def test_write_result(self):
@@ -723,7 +723,7 @@ def setUp(self) -> None:
723723
self.customer_tag = "California Miner"
724724

725725
def tearDown(self) -> None:
726-
self.write_client.__del__()
726+
self.write_client.close()
727727
super().tearDown()
728728

729729
def test_point_settings(self):
@@ -773,7 +773,7 @@ def setUp(self) -> None:
773773
os.environ['INFLUXDB_V2_TAG_DATA_CENTER'] = "${env.data_center}"
774774

775775
def tearDown(self) -> None:
776-
self.write_client.__del__()
776+
self.write_client.close()
777777
super().tearDown()
778778

779779
def test_connection_option_from_conf_file(self):

tests/test_WriteApiBatching.py

+8-8
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def setUp(self) -> None:
3131
self._write_client = WriteApi(influxdb_client=self.influxdb_client, write_options=self.write_options)
3232

3333
def tearDown(self) -> None:
34-
self._write_client.__del__()
34+
self._write_client.close()
3535
httpretty.disable()
3636

3737
def test_batch_size(self):
@@ -150,7 +150,7 @@ def test_flush_interval(self):
150150
httpretty.httpretty.latest_requests[1].parsed_body)
151151

152152
def test_jitter_interval(self):
153-
self._write_client.__del__()
153+
self._write_client.close()
154154
self._write_client = WriteApi(influxdb_client=self.influxdb_client,
155155
write_options=WriteOptions(batch_size=2, flush_interval=5_000,
156156
jitter_interval=3_000))
@@ -179,7 +179,7 @@ def test_jitter_interval(self):
179179

180180
def test_retry_interval(self):
181181

182-
self._write_client.__del__()
182+
self._write_client.close()
183183

184184
# Set retry interval to 1_500
185185
self.write_options = WriteOptions(batch_size=2, flush_interval=5_000, retry_interval=1_500)
@@ -226,7 +226,7 @@ def test_retry_interval_max_retries(self):
226226
httpretty.register_uri(httpretty.POST, uri="http://localhost/api/v2/write", status=429,
227227
adding_headers={'Retry-After': '1'})
228228

229-
self._write_client.__del__()
229+
self._write_client.close()
230230
self._write_client = WriteApi(influxdb_client=self.influxdb_client,
231231
write_options=WriteOptions(batch_size=2, flush_interval=5_000, max_retries=5))
232232

@@ -380,15 +380,15 @@ def test_del(self):
380380
_record = "h2o_feet,location=coyote_creek level\\ water_level=1 1"
381381
_result = self._write_client.write("my-bucket", "my-org", _record)
382382

383-
self._write_client.__del__()
383+
self._write_client.close()
384384

385385
_requests = httpretty.httpretty.latest_requests
386386

387387
self.assertEqual(1, len(_requests))
388388
self.assertEqual("h2o_feet,location=coyote_creek level\\ water_level=1 1", _requests[0].parsed_body)
389389

390390
def test_default_tags(self):
391-
self._write_client.__del__()
391+
self._write_client.close()
392392

393393
self.id_tag = "132-987-655"
394394
self.customer_tag = "California Miner"
@@ -431,7 +431,7 @@ def test_user_agent_header(self):
431431

432432
def test_to_low_flush_interval(self):
433433

434-
self._write_client.__del__()
434+
self._write_client.close()
435435
self._write_client = WriteApi(influxdb_client=self.influxdb_client,
436436
write_options=WriteOptions(batch_size=8,
437437
flush_interval=1,
@@ -448,7 +448,7 @@ def test_to_low_flush_interval(self):
448448
self._write_client.write("my-bucket", "my-org", [point_one, point_two])
449449
time.sleep(0.1)
450450

451-
self._write_client.__del__()
451+
self._write_client.close()
452452

453453
_requests = httpretty.httpretty.latest_requests
454454

tests/test_WriteApiDataFrame.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ def setUp(self) -> None:
2121

2222
def tearDown(self) -> None:
2323
super().tearDown()
24-
self._write_client.__del__()
24+
self._write_client.close()
2525

2626
def test_write_num_py(self):
2727
from influxdb_client.extras import pd, np
@@ -38,7 +38,7 @@ def test_write_num_py(self):
3838
write_api.write(bucket.name, record=data_frame, data_frame_measurement_name='h2o_feet',
3939
data_frame_tag_columns=['location'])
4040

41-
write_api.__del__()
41+
write_api.close()
4242

4343
result = self.query_api.query(
4444
"from(bucket:\"" + bucket.name + "\") |> range(start: 1970-01-01T00:00:00.000000001Z)",

tests/test_WriteApiPickle.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ def write(self, record):
1919
self.write_api.write(bucket="my-bucket", record=record)
2020

2121
def terminate(self) -> None:
22-
self.write_api.__del__()
23-
self.client.__del__()
22+
self.write_api.close()
23+
self.client.close()
2424

2525

2626
class WriteApiPickle(BaseTest):

0 commit comments

Comments
 (0)