Skip to content

Commit b5b6e44

Browse files
committed
chore: append task option at the end of script
1 parent 3a78bd8 commit b5b6e44

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

influxdb_client/client/tasks_api.py

+1-5
Original file line numberDiff line numberDiff line change
@@ -64,11 +64,7 @@ def _create_task(name: str, flux: str, every, cron, org_id: str) -> Task:
6464
repetition += "cron: "
6565
repetition += '"' + cron + '"'
6666

67-
from_index = flux.index("from")
68-
flux_with_options = \
69-
flux[0:from_index] + \
70-
'option task = {{name: "{}", {}}} \n\n'.format(name, repetition) + \
71-
flux[from_index:]
67+
flux_with_options = '{} \n\noption task = {{name: "{}", {}}}'.format(flux, name, repetition)
7268
task.flux = flux_with_options
7369

7470
return task

tests/test_TasksApi.py

+6-6
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def test_create_task_every(self):
121121
self.assertEqual(task.status, "active")
122122
self.assertEqual(task.every, "1h")
123123
self.assertEqual(task.cron, None)
124-
self.assertTrue(task.flux.endswith(TASK_FLUX))
124+
self.assertTrue(task.flux.startswith(TASK_FLUX))
125125

126126
def test_create_task_cron(self):
127127
task_name = self.generate_name("it task")
@@ -137,7 +137,7 @@ def test_create_task_cron(self):
137137
self.assertEqual(task.cron, "0 2 * * *")
138138
# self.assertEqualIgnoringWhitespace(task.flux, flux)
139139

140-
self.assertTrue(task.flux.endswith(TASK_FLUX))
140+
self.assertTrue(task.flux.startswith(TASK_FLUX))
141141
# self.assertEqual(task.links, "active")
142142

143143
links = task.links
@@ -165,8 +165,8 @@ def test_create_with_import(self):
165165
self.assertEqual(task.org_id, self.organization.id)
166166
self.assertEqual(task.status, "active")
167167
self.assertEqual(task.cron, "10 0 * * * *")
168-
self.assertTrue(task.flux.startswith('import "http"\n\noption task = '))
169-
self.assertTrue(task.flux.endswith(' |> aggregateWindow(every: 1h, fn: mean)'))
168+
self.assertTrue(task.flux.startswith(task_flux))
169+
self.assertTrue(task.flux.splitlines()[-1].startswith('option task = '))
170170

171171
def test_find_task_by_id(self):
172172
task_name = self.generate_name("it task")
@@ -199,12 +199,12 @@ def test_update_task(self):
199199
cron_task = self.tasks_api.create_task_cron(task_name, TASK_FLUX, "0 2 * * *", self.organization.id)
200200

201201
flux = '''
202+
{flux}
203+
202204
option task = {{
203205
name: "{task_name}",
204206
every: 3m
205207
}}
206-
207-
{flux}
208208
'''.format(task_name=task_name, flux=TASK_FLUX)
209209

210210
cron_task.cron = None

0 commit comments

Comments
 (0)