Skip to content

08. Reviewing pull requests

Ilkka Seppälä edited this page Oct 3, 2015 · 29 revisions

As a reviewer, you need to ensure

  • Put under review badge to the pull request
  • Does the example code implement the pattern correctly and follow good coding practices?
  • Does the example code have enough test coverage?
  • Is the example code commented well enough?
  • Is the example code following JavaDoc conventions?
  • Are the project coding conventions being followed?
  • Is the class diagram generated correctly?
  • Is the index.md implemented correctly so the pattern will show correctly on the web site?

As a general guideline, pull requests with no activity during the last 30 days will be closed.

Clone this wiki locally