Skip to content

Translation to other languages #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sudowanderer opened this issue May 26, 2020 · 30 comments
Closed

Translation to other languages #1245

sudowanderer opened this issue May 26, 2020 · 30 comments

Comments

@sudowanderer
Copy link
Contributor

sudowanderer commented May 26, 2020

#I think this is a very nice repo to learn java design patterns.But as I see, there still no translations for other languages.So I want to join this repo and translate this into chinese if It's possible.(I' m a Chinese)

@iluwatar
Copy link
Owner

@xiaod-dev this is a roadmap item we haven't started to implement yet. See https://github.com/iluwatar/java-design-patterns/wiki/13.-Roadmap.

For these kind of larger roadmap items we usually design it first into the wiki https://github.com/iluwatar/java-design-patterns/wiki and then chop it into smaller pieces to make it implementable.

@xiaod-dev if you're interested to take on this kind of bigger task then I would suggest to start it from the design vision. I'll support you of course where ever help is needed.

@sudowanderer
Copy link
Contributor Author

sudowanderer commented Jun 2, 2020

You mean I should edit the wiki first?It seems I have no rights to do this. And another problem, I don't know the organize rules of translated files...

@iluwatar
Copy link
Owner

iluwatar commented Jun 2, 2020

Yes, @xiaod-dev we need to plan how the internationalization will be implemented. Can you try editing the wiki again? I updated the access rights so that anyone can edit. What comes to the organization rules this is what we need to design and document among other things.

@iluwatar
Copy link
Owner

iluwatar commented Jun 2, 2020

@xiaod-dev here's an example roadmap item that was designed earlier https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition.

@sudowanderer
Copy link
Contributor Author

I write a first simple version of "15.-Support-for-multiple-languages".Help me review it if there is something missing or wrong. I think we should just use one method to organize our translated files.
https://github.com/iluwatar/java-design-patterns/wiki/15.-Support-for-multiple-languages

@iluwatar
Copy link
Owner

iluwatar commented Jun 7, 2020

Thanks for working on this @xiaod-dev. In this design document we need to envision how we want the end result to look like. We have multiple ways how the user can approach the repository:

  1. Browse the Github repository directly https://github.com/iluwatar/java-design-patterns
  2. Use the web site https://java-design-patterns.com

For 1) one option is to use links to translations like described here https://github.community/t/how-to-localize-the-readme-file/1756.
For 2) we could have a language selector component in the Bootstrap navbar. Based on the selection the web site (https://github.com/iluwatar/java-design-patterns-web) would then render the site using the correct language files.

There could be other good alternatives as well. Can you think of any? In any case we need to write down the objective very clearly and preferably with pictures. Then we can start dividing the overall goals into manageable tasks.

For the methods (append language code or create a directory) you mention in https://github.com/iluwatar/java-design-patterns/wiki/15.-Support-for-multiple-languages I think we should evaluate pros and cons of each approach. For 1) either one probably works as good but for 2) there may be technical limitations that will drive our approach.

@sudowanderer
Copy link
Contributor Author

Actually,I don't know how the website works.It seems like it is a static web project and use the original docs from this repo. Is it use github io?
I find a previous issue on the java-design-patterns-web repo.iluwatar/java-design-patterns-web#3
Is there any chance that we could use gitlocalize to translate?

@iluwatar
Copy link
Owner

iluwatar commented Jun 7, 2020

Yes, that's correct. The web site is a static one generated with Jekyll and uses the markdown files from the repository. The site is served from AWS S3 and uses CloudFront CDN.
At first glance I think gitlocalize looks good and we could try it out. Yes, iluwatar/java-design-patterns-web#3 is related issue.

@MiJack
Copy link

MiJack commented Jun 11, 2020

It seems that the website gitlocalize provide a good experience for the translation. If gitlocalize can provide a Jekyll plugin, we can use it for the multi-language website.

@iluwatar
Copy link
Owner

iluwatar commented Jul 6, 2020

@xiaod-dev are you working on this? Let me know if you need assistance.

@sudowanderer
Copy link
Contributor Author

sudowanderer commented Jul 7, 2020

I think we can use gitlocalize.The website shows that GitLocalize can work with any static site generators including Jekyll.
https://docs.gitlocalize.com/file_formats.html
and I forked this repo into my own git account to initialize it in GitLocalize.The repo url is https://github.com/xiaod-dev/java-design-patterns.
I try to translated the root readme doc in chinese.The url is https://github.com/xiaod-dev/java-design-patterns/tree/master/zh-CN.
And if I translated the adapter chapter,the translated file will be in "zh-CN/adapter/README.md".
So,

  1. Is it right that I forked the repo to initialize GitLocalize?As I know,I am not the member of this repo,So I can't initialize GitLocalize in the original repo.If it is right,I need send PR to you after I have updates.Besides, It will more convenient if I initialize GitLocalize in the original repo, cos I don't need send PR to forked repo(myself).
  2. organize rules of translated files are shown above.It is fine?
  3. help me check out if the GitLocalize is work well with Jekyll.

@iluwatar
Copy link
Owner

iluwatar commented Jul 7, 2020

Is it right that I forked the repo to initialize GitLocalize?As I know,I am not the member of this repo,So I can't initialize GitLocalize in the original repo.If it is right,I need send PR to you after I have updates.Besides, It will more convenient if I initialize GitLocalize in the original repo, cos I don't need send PR to forked repo(myself).

@xiaod-dev since you're working on big important feature I'll add you as a collaborator. Then you should be able to initialize GitLocalize with the main repository.

organize rules of translated files are shown above.It is fine?

Yes, I'm ok to start with that

help me check out if the GitLocalize is work well with Jekyll.

Yes, you have my full support. Just let me know what's needed.

@sudowanderer
Copy link
Contributor Author

sudowanderer commented Jul 7, 2020

It seems that only the owner of repository can initialize GitLocalize. Please help me initialize GitLocalize through this gitlocalize.com:. And add me as a member of Team(Moderator)

@iluwatar
Copy link
Owner

iluwatar commented Jul 7, 2020

Ok, done. It started syncing now.

image

@iluwatar
Copy link
Owner

iluwatar commented Jul 7, 2020

@iluwatar
Copy link
Owner

@all-contributors please add @xiaod-dev for translation

@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @xiaod-dev! 🎉

@iluwatar
Copy link
Owner

@xiaod-dev are you still working on this, and do you need assistance?

@sudowanderer
Copy link
Contributor Author

sudowanderer commented Aug 19, 2020

@iluwatar yeah, I got some problems here. The Gitlocalize shows application error when I try to access this url .Can you visit this page successfully? I send emails and send messages through their homepage,also submit a issue but still got no responses.....In that case, I think I have to translate things manually.

@iluwatar
Copy link
Owner

@xiaod-dev yes, it shows me the application error as well when visiting the above url.

@iluwatar
Copy link
Owner

In the settings view there's an option to delete a language. Should we try deleting and adding it again? The translations so far can be accessed from git history anyway.
image

@sudowanderer
Copy link
Contributor Author

@iluwatar yeah, I think we can have a try. And if it doesn't work, may be we can delete the hole project in gitlocalize and add it again?

@iluwatar
Copy link
Owner

Tried deleting the language and adding it again, but still it gives the same error message. Also when trying to delete the whole repo from gitlocalize the same error message is given 😿

@sudowanderer
Copy link
Contributor Author

Ah...In that way,I think temporarily I have to translate and send pull request manually...

@iluwatar
Copy link
Owner

Yes, unfortunately I don't see many other options 🙍🏻‍♂️

@iluwatar
Copy link
Owner

@xiaod-dev any updates from gitlocalize project? It would be an asset if we could use it. I working on a new web site that will be able to utilize the translations.

@sudowanderer
Copy link
Contributor Author

sudowanderer commented Feb 1, 2021

@xiaod-dev any updates from gitlocalize project? It would be an asset if we could use it. I working on a new web site that will be able to utilize the translations.

@iluwatar Since last time the gitlocalize occurs error, I don' t use it any more. I translate with google and process it by myself. You mentioned a new website, Could you share the website or is there anything I can collaborate with you?

@iluwatar
Copy link
Owner

iluwatar commented Feb 7, 2021

It's still very much in progress, but what I currently have can be seen here: https://fervent-booth-169ea6.netlify.app/
The code repository is https://github.com/iluwatar/java-design-patterns-vuepress-web

@iluwatar iluwatar changed the title i18n of this repo Translation to other languages Oct 24, 2021
@iluwatar
Copy link
Owner

iluwatar commented Nov 1, 2021

Help needed in translating the new website to Chinese. See iluwatar/java-design-patterns-vuepress-web#13

@iluwatar
Copy link
Owner

Hey guys, since there are many languages incoming I've decided to split this issue into individual target languages. If you are willing to help, please look for issues such as "Translate to Chinese" and add a comment to indicate you are willing to work on it. I can then assign the issue to you.

Repository owner moved this from Todo to Done in Java Design Patterns project Oct 30, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants