added scope before class definition in Test classes & removed duplicate dependency from pom.xml & added required one

Author: quantdevv

Diff for: polling-publisher/polling-service/src/main/java/com/iluwatar/polling/App.java

@@ -29,9 +29,7 @@
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 import org.springframework.scheduling.annotation.EnableScheduling;
 
-/**
- * Polling-Publisher pattern paradigm.
- */
+/** Polling-Publisher pattern paradigm. */
 @SpringBootApplication
 @EnableScheduling
 public class App {

Diff for: polling-publisher/polling-service/src/main/java/com/iluwatar/polling/DataRepository.java

@@ -30,18 +30,13 @@
 import javax.annotation.PostConstruct;
 import org.springframework.stereotype.Repository;
 
-
-/**
- * Data repository to keep or store data.
- */
+/** Data repository to keep or store data. */
 @Repository
 public class DataRepository {
 
   private final Map<Integer, String> dataStorage = new HashMap<>();
 
-  /**
-   * init after map creation ... to put dummy data.
-   */
+  /** init after map creation ... to put dummy data. */
   @PostConstruct
   public void init() {
     // Injecting dummy data at startup
@@ -50,31 +45,22 @@ public void init() {
     dataStorage.put(4, "Initial Dummy Data - four - 4");
   }
 
-
-  /**
-   * Save data to the repository.
-   */
+  /** Save data to the repository. */
   public void save(int id, String value) {
     dataStorage.put(id, value);
   }
 
-  /**
-   * Retrieve data by ID.
-   */
+  /** Retrieve data by ID. */
   public String findById(int id) {
     return dataStorage.getOrDefault(id, "Data not found");
   }
 
-  /**
-   * Delete data by ID.
-   */
+  /** Delete data by ID. */
   public void delete(int id) {
     dataStorage.remove(id);
   }
 
-  /**
-   * Get all data.
-   */
+  /** Get all data. */
   public Map<Integer, String> findAll() {
     return dataStorage;
   }

Diff for: polling-publisher/polling-service/src/main/java/com/iluwatar/polling/DataSourceService.java

@@ -25,42 +25,38 @@
 
 package com.iluwatar.polling;
 
-import java.util.List;
 import java.util.Map;
 import java.util.Random;
 import org.springframework.stereotype.Service;
 
-/**
- * This class is responsible for keep the events.
- */
+/** This class is responsible for keep the events. */
 @Service
 public class DataSourceService {
 
   private final DataRepository repository;
 
-  /**
-   * Constructor & Scheduler to push random data.
-   */
+  /** Constructor & Scheduler to push random data. */
   public DataSourceService(DataRepository repository) {
     this.repository = repository;
 
     // Start a separate thread to add data every 3 seconds
-    new Thread(() -> {
-      Random random = new Random();
-      while (true) {
-        try {
-          Thread.sleep(3000); // Add data every 3 seconds
-          int id = random.nextInt(100); // Random ID
-          String value = "Auto-Data-" + id;
-          this.addData(id, value);
-          System.out.println("🔵 Data Added: " + id + " -> " + value);
-        } catch (InterruptedException e) {
-          Thread.currentThread().interrupt();
-          break;
-        }
-      }
-    }).start();
-
+    new Thread(
+            () -> {
+              Random random = new Random();
+              while (true) {
+                try {
+                  Thread.sleep(3000); // Add data every 3 seconds
+                  int id = random.nextInt(100); // Random ID
+                  String value = "Auto-Data-" + id;
+                  this.addData(id, value);
+                  System.out.println("🔵 Data Added: " + id + " -> " + value);
+                } catch (InterruptedException e) {
+                  Thread.currentThread().interrupt();
+                  break;
+                }
+              }
+            })
+        .start();
   }
 
   public void addData(int id, String value) {

Diff for: polling-publisher/polling-service/src/main/java/com/iluwatar/polling/KafkaProducer.java

@@ -29,15 +29,11 @@
 import org.springframework.kafka.core.KafkaTemplate;
 import org.springframework.stereotype.Component;
 
-
-/**
- * This class is responsible for sending messages to Kafka.
- */
+/** This class is responsible for sending messages to Kafka. */
 @Component
 public class KafkaProducer {
 
-  @Autowired
-  private final KafkaTemplate<String, String> kafkaTemplate;
+  @Autowired private final KafkaTemplate<String, String> kafkaTemplate;
 
   public KafkaProducer(KafkaTemplate<String, String> kafkaTemplate) {
     this.kafkaTemplate = kafkaTemplate;
@@ -51,4 +47,4 @@ public KafkaProducer(KafkaTemplate<String, String> kafkaTemplate) {
   public void sendMessage(String topic, String message) {
     kafkaTemplate.send(topic, message);
   }
-}
+}

Diff for: polling-publisher/polling-service/src/main/java/com/iluwatar/polling/PollingController.java

@@ -31,9 +31,7 @@
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 
-/**
- * This class is responsible for contolling polling tasks.
- */
+/** This class is responsible for contolling polling tasks. */
 @RestController
 public class PollingController {
 
@@ -42,13 +40,11 @@ public String healthCheck() {
     return "Polling Service is up and running!";
   }
 
-
-  @Autowired
-  private KafkaProducer kafkaProducer;
+  @Autowired private KafkaProducer kafkaProducer;
 
   @PostMapping("/send")
   public String sendMessage(@RequestParam("message") String message) {
     kafkaProducer.sendMessage("API", message);
     return "Message sent: " + message;
   }
-}
+}

Diff for: polling-publisher/polling-service/src/main/java/com/iluwatar/polling/PollingScheduler.java

@@ -30,21 +30,15 @@
 import org.springframework.scheduling.annotation.Scheduled;
 import org.springframework.stereotype.Component;
 
-/**
- * This class is responsible for scheduling polling tasks.
- */
+/** This class is responsible for scheduling polling tasks. */
 @Component
 public class PollingScheduler {
 
-  @Autowired
-  private DataSourceService dataSourceService;
+  @Autowired private DataSourceService dataSourceService;
 
-  @Autowired
-  private KafkaProducer kafkaProducer;
+  @Autowired private KafkaProducer kafkaProducer;
 
-  /**
-   * Scheduler for poll data on each 5 second.
-   * */
+  /** Scheduler for poll data on each 5 second. */
   @Scheduled(fixedRate = 5000) // Poll every 5 seconds
   public void pollDataSource() {
     int id = new Random().nextInt(100); // Pick a random ID
@@ -57,4 +51,4 @@ public void pollDataSource() {
       System.out.println("🔴 No Data Found for ID: " + id);
     }
   }
-}
+}

Diff for: polling-publisher/polling-service/src/test/java/com/iluwatar/polling/AppTest.java

@@ -24,17 +24,16 @@
  */
 package com.iluwatar.polling;
 
-import org.junit.jupiter.api.Disabled;
+import static org.junit.jupiter.api.Assertions.*;
+
 import org.junit.jupiter.api.Test;
 import org.springframework.boot.test.context.SpringBootTest;
 
-import static org.junit.jupiter.api.Assertions.*;
-
 @SpringBootTest
 public class AppTest {
 
   @Test
   void polling() {
-    assertDoesNotThrow(() -> App.main(new String[]{}));
+    assertDoesNotThrow(() -> App.main(new String[] {}));
   }
 }

Diff for: polling-publisher/polling-service/src/test/java/com/iluwatar/polling/DataRepositoryTest.java

@@ -24,14 +24,13 @@
  */
 package com.iluwatar.polling;
 
-import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
-
 import static org.junit.jupiter.api.Assertions.*;
 
 import java.util.Map;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
-class DataRepositoryTest {
+public class DataRepositoryTest {
 
   private DataRepository repository;
 

Diff for: polling-publisher/polling-service/src/test/java/com/iluwatar/polling/DataSourceServiceTest.java

@@ -25,12 +25,12 @@
 
 package com.iluwatar.polling;
 
-import org.junit.jupiter.api.*;
-import java.util.Map;
-
 import static org.junit.jupiter.api.Assertions.*;
 
-class DataSourceServiceTest {
+import java.util.Map;
+import org.junit.jupiter.api.*;
+
+public class DataSourceServiceTest {
 
   private DataRepository repository;
   private DataSourceService service;
@@ -63,8 +63,8 @@ void testRemoveData() {
 
     service.removeData(2);
 
-    assertEquals("Data not found", repository.findById(2), "Deleted data should not be retrievable.");
-
+    assertEquals(
+        "Data not found", repository.findById(2), "Deleted data should not be retrievable.");
   }
 
   @Test

Diff for: polling-publisher/pom.xml

@@ -43,30 +43,30 @@
 
     <properties>
         <java.version>21</java.version>
-        <spring.boot.version>3.2.2</spring.boot.version>
+        <spring.boot.version>3.4.4</spring.boot.version>
     </properties>
 
     <dependencies>
         <!-- https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-api -->
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-api</artifactId>
-            <version>5.10.1</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.junit.jupiter</groupId>
-            <artifactId>junit-jupiter-engine</artifactId>
-            <version>5.9.2</version>
-            <scope>test</scope>
-        </dependency>
-        <dependency>
-            <groupId>org.springframework.boot</groupId>
-            <artifactId>spring-boot-dependencies</artifactId>
-            <version>${spring.boot.version}</version>
-            <type>pom</type>
-            <scope>import</scope>
-        </dependency>
+<!--        <dependency>-->
+<!--            <groupId>org.junit.jupiter</groupId>-->
+<!--            <artifactId>junit-jupiter-api</artifactId>-->
+<!--            <version>5.10.1</version>-->
+<!--            <scope>test</scope>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>org.junit.jupiter</groupId>-->
+<!--            <artifactId>junit-jupiter-engine</artifactId>-->
+<!--            <version>5.9.2</version>-->
+<!--            <scope>test</scope>-->
+<!--        </dependency>-->
+<!--        <dependency>-->
+<!--            <groupId>org.springframework.boot</groupId>-->
+<!--            <artifactId>spring-boot-dependencies</artifactId>-->
+<!--            <version>${spring.boot.version}</version>-->
+<!--            <type>pom</type>-->
+<!--            <scope>import</scope>-->
+<!--        </dependency>-->
         <dependency>
             <groupId>org.springframework.boot</groupId>
             <artifactId>spring-boot-starter-web</artifactId>
@@ -127,6 +127,18 @@
             <version>1.3.2</version>
         </dependency>
 
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-core</artifactId>
+            <version>1.5.18</version>
+        </dependency>
+        <dependency>
+            <groupId>ch.qos.logback</groupId>
+            <artifactId>logback-classic</artifactId>
+            <version>1.5.18</version>
+        </dependency>
+
+
 
     </dependencies>
 
@@ -143,6 +155,11 @@
                         <target>21</target>
                     </configuration>
                 </plugin>
+                <plugin>
+                    <groupId>org.apache.maven.plugins</groupId>
+                    <artifactId>maven-surefire-plugin</artifactId>
+                    <version>2.22.2</version>
+                </plugin>
             </plugins>
         </pluginManagement>
     </build>

Diff for: polling-publisher/subscriber-service/src/main/java/com/iluwatar/subscriber/App.java

@@ -28,13 +28,10 @@
 import org.springframework.boot.SpringApplication;
 import org.springframework.boot.autoconfigure.SpringBootApplication;
 
-/**
- * Polling-Publisher pattern paradigm.
-*/
+/** Polling-Publisher pattern paradigm. */
 @SpringBootApplication
 public class App {
   public static void main(String[] args) {
     SpringApplication.run(App.class, args);
   }
 }
-

Diff for: polling-publisher/subscriber-service/src/main/java/com/iluwatar/subscriber/KafkaConsumer.java

@@ -27,9 +27,8 @@
 
 import org.springframework.kafka.annotation.KafkaListener;
 import org.springframework.stereotype.Service;
-/**
- * Kafka consumer service to consume messages / updates.
- * */
+
+/** Kafka consumer service to consume messages / updates. */
 @Service
 public class KafkaConsumer {
 
@@ -42,4 +41,4 @@ public void listenUpdates(String message) {
   public void listenApi(String message) {
     System.out.println("[API]: Received message from /send : " + message);
   }
-}
+}