Skip to content

Commit 3ac7cc3

Browse files
authored
refactor: Composite View (#2886)
* chore : upgrade the jackson-databind to latest version(2.17.0) * refactor: refactor Composite View * refactor: remove unnecessary chnges related to this PR(#2853) * fix: checkstyle error in AppServlet.java
1 parent e0b1250 commit 3ac7cc3

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java

+20-16
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,17 @@
2525
package com.iluwatar.compositeview;
2626

2727
import jakarta.servlet.RequestDispatcher;
28-
import jakarta.servlet.ServletException;
2928
import jakarta.servlet.http.HttpServlet;
3029
import jakarta.servlet.http.HttpServletRequest;
3130
import jakarta.servlet.http.HttpServletResponse;
32-
import java.io.IOException;
3331
import java.io.PrintWriter;
32+
import lombok.extern.slf4j.Slf4j;
3433

3534
/**
3635
* A servlet object that extends HttpServlet.
3736
* Runs on Tomcat 10 and handles Http requests
3837
*/
39-
38+
@Slf4j
4039
public final class AppServlet extends HttpServlet {
4140
private static final String CONTENT_TYPE = "text/html";
4241
private String msgPartOne = "<h1>This Server Doesn't Support";
@@ -56,39 +55,44 @@ public AppServlet() {
5655
}
5756

5857
@Override
59-
public void doGet(HttpServletRequest req, HttpServletResponse resp)
60-
throws ServletException, IOException {
61-
RequestDispatcher requestDispatcher = req.getRequestDispatcher(destination);
62-
ClientPropertiesBean reqParams = new ClientPropertiesBean(req);
63-
req.setAttribute("properties", reqParams);
64-
requestDispatcher.forward(req, resp);
58+
public void doGet(HttpServletRequest req, HttpServletResponse resp) {
59+
try {
60+
RequestDispatcher requestDispatcher = req.getRequestDispatcher(destination);
61+
ClientPropertiesBean reqParams = new ClientPropertiesBean(req);
62+
req.setAttribute("properties", reqParams);
63+
requestDispatcher.forward(req, resp);
64+
} catch (Exception e) {
65+
LOGGER.error("Exception occurred GET request processing ", e);
66+
}
6567
}
6668

6769
@Override
68-
public void doPost(HttpServletRequest req, HttpServletResponse resp)
69-
throws ServletException, IOException {
70+
public void doPost(HttpServletRequest req, HttpServletResponse resp) {
7071
resp.setContentType(CONTENT_TYPE);
7172
try (PrintWriter out = resp.getWriter()) {
7273
out.println(msgPartOne + " Post " + msgPartTwo);
74+
} catch (Exception e) {
75+
LOGGER.error("Exception occurred POST request processing ", e);
7376
}
74-
7577
}
7678

7779
@Override
78-
public void doDelete(HttpServletRequest req, HttpServletResponse resp)
79-
throws ServletException, IOException {
80+
public void doDelete(HttpServletRequest req, HttpServletResponse resp) {
8081
resp.setContentType(CONTENT_TYPE);
8182
try (PrintWriter out = resp.getWriter()) {
8283
out.println(msgPartOne + " Delete " + msgPartTwo);
84+
} catch (Exception e) {
85+
LOGGER.error("Exception occurred DELETE request processing ", e);
8386
}
8487
}
8588

8689
@Override
87-
public void doPut(HttpServletRequest req, HttpServletResponse resp)
88-
throws ServletException, IOException {
90+
public void doPut(HttpServletRequest req, HttpServletResponse resp) {
8991
resp.setContentType(CONTENT_TYPE);
9092
try (PrintWriter out = resp.getWriter()) {
9193
out.println(msgPartOne + " Put " + msgPartTwo);
94+
} catch (Exception e) {
95+
LOGGER.error("Exception occurred PUT request processing ", e);
9296
}
9397
}
9498
}

0 commit comments

Comments
 (0)