Skip to content

Commit 3806bdc

Browse files
committed
Revert "Refine message wait logic in MessageConsumerImpl"
This reverts commit c810f9e.
1 parent c810f9e commit 3806bdc

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/main/java/com/swiftmq/jms/v750/MessageConsumerImpl.java

+5-8
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ void addToCache(AsyncMessageDeliveryRequest request) {
130130
if (request.isRequiresRestart())
131131
fillCachePending.set(false);
132132
messageCache.add(request);
133-
waiter.signal();
134133
}
135134

136135
void addToCache(AsyncMessageDeliveryRequest[] requests, boolean lastRestartRequired) {
@@ -373,14 +372,12 @@ Message receiveMessage(boolean block, long timeout) throws JMSException {
373372
} else {
374373
long deadline = System.nanoTime() + TimeUnit.MILLISECONDS.toNanos(timeout);
375374
long remaining;
376-
while (true) {
377-
if (messageCache.getSize() > 0 || !fillCachePending.get() || cancelled.get() || isClosed())
378-
break;
379-
380-
remaining = deadline - System.nanoTime();
381-
if (remaining <= 0)
382-
break;
383375

376+
while ((remaining = deadline - System.nanoTime()) > 0 &&
377+
messageCache.getSize() == 0 &&
378+
fillCachePending.get() &&
379+
!cancelled.get() &&
380+
!isClosed()) {
384381
waiter.doWait(TimeUnit.NANOSECONDS.toMillis(remaining));
385382
}
386383
}

0 commit comments

Comments
 (0)