From 36e713b147824df125bcabb8f835ea5c4d519e8d Mon Sep 17 00:00:00 2001 From: Ignacio Chiazzo Cardarello Date: Sat, 29 Oct 2022 16:15:41 -0400 Subject: [PATCH 1/2] Create pull_request_template.md cc @hot9cups --- pull_request_template.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000..734bf60 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,9 @@ +## Title of the problem + +## Checklist before requesting a review +- [ ] I have checked the [guide](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript#contributions) for contributions. +- [ ] I have added the description at the top of the solution file. +- [ ] I have added a test file for the problem. +- [ ] I have added an entry to the [README](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/blob/master/README.md) file with a link to the new file. + +Check the [guide](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript#contributions) and [this PR](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/pull/39) example. From 8500cba5ada48c0e052c8e6853a1aec5c7cbb5b2 Mon Sep 17 00:00:00 2001 From: Ignacio Chiazzo Cardarello Date: Sat, 29 Oct 2022 23:35:10 -0400 Subject: [PATCH 2/2] Update pull_request_template.md --- pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/pull_request_template.md b/pull_request_template.md index 734bf60..a2e90bb 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -5,5 +5,6 @@ - [ ] I have added the description at the top of the solution file. - [ ] I have added a test file for the problem. - [ ] I have added an entry to the [README](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/blob/master/README.md) file with a link to the new file. +- [ ] I have run linter (`npx eslint LeetcodeProblems LeetcodeProblemsTests`) and unit tests (`node Test.js`) and they pass. [More info](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript#run-tests). Check the [guide](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript#contributions) and [this PR](https://github.com/ignacio-chiazzo/Algorithms-Leetcode-Javascript/pull/39) example.