IDCOM-2129 Fixing the extend_transaction realloc issue. This was the problem: rust-lang/rust#39232

Author: dankelleher

packages/client/idl/src/cryptid.ts

@@ -218,6 +218,84 @@ export type Cryptid = {
         }
       ]
     },
+    {
+      "name": "extendTransaction",
+      "accounts": [
+        {
+          "name": "cryptidAccount",
+          "isMut": false,
+          "isSigner": false,
+          "docs": [
+            "The Cryptid instance that can execute the transaction."
+          ]
+        },
+        {
+          "name": "did",
+          "isMut": false,
+          "isSigner": false,
+          "docs": [
+            "The did account owner of the Cryptid instance"
+          ]
+        },
+        {
+          "name": "didProgram",
+          "isMut": false,
+          "isSigner": false,
+          "docs": [
+            "The program for the DID"
+          ]
+        },
+        {
+          "name": "authority",
+          "isMut": true,
+          "isSigner": true
+        },
+        {
+          "name": "transactionAccount",
+          "isMut": true,
+          "isSigner": false
+        },
+        {
+          "name": "systemProgram",
+          "isMut": false,
+          "isSigner": false
+        }
+      ],
+      "args": [
+        {
+          "name": "controllerChain",
+          "type": {
+            "vec": {
+              "defined": "DIDReference"
+            }
+          }
+        },
+        {
+          "name": "cryptidAccountBump",
+          "type": "u8"
+        },
+        {
+          "name": "cryptidAccountIndex",
+          "type": "u32"
+        },
+        {
+          "name": "didAccountBump",
+          "type": "u8"
+        },
+        {
+          "name": "instructions",
+          "type": {
+            "vec": {
+              "defined": "AbbreviatedInstructionData"
+            }
+          }
+        },
+        {
+          "name": "numAccounts",
+          "type": "u8"
+        }
+      ]
+    },
     {
       "name": "sealTransaction",
       "accounts": [
@@ -911,6 +989,84 @@ export const IDL: Cryptid = {
         }
       ]
     },
+    {
+      "name": "extendTransaction",
+      "accounts": [
+        {
+          "name": "cryptidAccount",
+          "isMut": false,
+          "isSigner": false,
+          "docs": [
+            "The Cryptid instance that can execute the transaction."
+          ]
+        },
+        {
+          "name": "did",
+          "isMut": false,
+          "isSigner": false,
+          "docs": [
+            "The did account owner of the Cryptid instance"
+          ]
+        },
+        {
+          "name": "didProgram",
+          "isMut": false,
+          "isSigner": false,
+          "docs": [
+            "The program for the DID"
+          ]
+        },
+        {
+          "name": "authority",
+          "isMut": true,
+          "isSigner": true
+        },
+        {
+          "name": "transactionAccount",
+          "isMut": true,
+          "isSigner": false
+        },
+        {
+          "name": "systemProgram",
+          "isMut": false,
+          "isSigner": false
+        }
+      ],
+      "args": [
+        {
+          "name": "controllerChain",
+          "type": {
+            "vec": {
+              "defined": "DIDReference"
+            }
+          }
+        },
+        {
+          "name": "cryptidAccountBump",
+          "type": "u8"
+        },
+        {
+          "name": "cryptidAccountIndex",
+          "type": "u32"
+        },
+        {
+          "name": "didAccountBump",
+          "type": "u8"
+        },
+        {
+          "name": "instructions",
+          "type": {
+            "vec": {
+              "defined": "AbbreviatedInstructionData"
+            }
+          }
+        },
+        {
+          "name": "numAccounts",
+          "type": "u8"
+        }
+      ]
+    },
     {
       "name": "sealTransaction",
       "accounts": [

programs/cryptid/src/instructions/extend_transaction.rs

@@ -9,7 +9,6 @@ use crate::state::transaction_state::TransactionState;
 use crate::util::SolDID;
 use anchor_lang::prelude::*;
 use itertools::Itertools;
-use std::borrow::BorrowMut;
 
 #[derive(Accounts)]
 #[instruction(
@@ -97,11 +96,11 @@ impl ExtendTransaction<'_> {
         // if the account is not in all_accounts, add it to the transaction_accounts and update the index in the instruction
         new_instructions.iter_mut().for_each(
             |new_instruction: &mut &mut AbbreviatedInstructionData| {
-                new_instruction.accounts.iter_mut().map(
+                new_instruction.accounts.iter_mut().for_each(
                     |mut new_instruction_account_meta: &mut AbbreviatedAccountMeta| {
                         let account =
                             new_instruction_accounts[new_instruction_account_meta.key as usize];
-                        if let Some((index, key)) = transaction_account
+                        if let Some((index, _key)) = transaction_account
                             .accounts
                             .iter()
                             .find_position(|existing_account| *existing_account == account.key)