[feature firebase-migration]: Refactor post saving of players

Author: idanen

app/scripts/manager/manager-ctrl.js

@@ -41,26 +41,6 @@ angular.module( 'pokerManager' ).
 
 		vm.init();
 
-		function playerSaved( savedPlayer ) {
-			// console.log('savedPlayer = ' + savedPlayer);
-			var isNew = true,
-				playerIdx, len,
-				players = vm.players;
-			
-			for ( playerIdx = 0, len = players.length; playerIdx < len; ++playerIdx ) {
-				if ( players[ playerIdx ].id === savedPlayer.id) {
-					isNew = false;
-					break;
-				}
-			}
-			
-			if ( isNew ) {
-				players.push( savedPlayer );
-			} else {
-				players[ playerIdx ] = savedPlayer;
-			}
-		}
-
 		function openPlayersControl() {
 			vm.prefs.playersOpen = !vm.prefs.playersOpen;
 		}
@@ -184,15 +164,13 @@ angular.module( 'pokerManager' ).
 					if ( savedPlayer.isNew ) {
 						savedPlayer.buyin = 0;
 						savedPlayer.isPlaying = false;
-					// Update changed fields
+						vm.players.push( savedPlayer );
 					}
 
 					player = savedPlayer;
-					
-					// Model.savePlayer( player );
+
 					return Players.update( player ).$promise;
-				} )
-				.then( playerSaved );
+				} );
 		}
 
 		$scope.$watch( function () {

app/scripts/services/communities.service.js

@@ -54,25 +54,6 @@ angular.module( 'pokerManager' ).
 		vm.filterPlayers = filterPlayers;
 		vm.playerPredicate = playerPredicate;
 
-		function playerSaved( savedPlayer ) {
-			// console.log('savedPlayer = ' + savedPlayer);
-			var isNew = true,
-				playerIdx,
-				players = vm.displayGames.players;
-			
-			isNew = players.some( function ( player ) {
-				return player.id === savedPlayer.id;
-			} );
-			
-			if ( isNew ) {
-				players.push( savedPlayer );
-			} else {
-				savedPlayer.buyin = players[ playerIdx ].buyin;
-				savedPlayer.buyout = players[ playerIdx ].buyout;
-				players[ playerIdx ] = savedPlayer;
-			}
-		}
-
 		function formatDate( aDate ) {
 			return $filter( 'date' )( aDate, 'y-MM-dd' );
 		}
@@ -183,17 +164,15 @@ angular.module( 'pokerManager' ).
 		function openPlayerDetailsDialog( player ) {
 			playerModal.open( player )
 				.then( function ( savedPlayer ) {
-					// If new -> update default values
-					if ( isNew ) {
-						savedPlayer.buyin = 0;
-						savedPlayer.isPlaying = false;
-					}
-					
-					player = savedPlayer;
-					
-					return Players.update( player ).$promise;
-				} )
-				.then( playerSaved );;
+					/*
+					 * Update the local instance if the player with the changeable fields from the modal
+					 */
+					player.name = savedPlayer.name;
+					player.phone = savedPlayer.phone;
+					player.email = savedPlayer.email;
+
+					return Players.update( savedPlayer ).$promise;
+				} );
 		}
 	}
 })();