Skip to content

Commit efa51e4

Browse files
committed
fix(accordion): add open class when expanded
- add `open` class to `.panel-collapse` when open. - fix missing closing `<` on test. fixes angular-ui#3419
1 parent 895a228 commit efa51e4

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

src/accordion/test/accordion.spec.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ describe('accordion', function () {
114114
it('should expose the controller on the view', function () {
115115
$templateCache.put('template/accordion/accordion.html', '<div>{{accordion.text}}</div>');
116116

117-
element = $compile('<accordion></accordion')(scope);
117+
element = $compile('<accordion></accordion>')(scope);
118118
scope.$digest();
119119

120120
var ctrl = element.controller('accordion');
@@ -211,6 +211,16 @@ describe('accordion', function () {
211211
scope.$digest();
212212
expect(findGroupBody(0).scope().isOpen).toBe(false);
213213
});
214+
215+
it('should add "open" when opened', function() {
216+
findGroupLink(0).click();
217+
scope.$digest();
218+
expect(findGroupBody(0)).toHaveClass('open');
219+
220+
findGroupLink(0).click();
221+
scope.$digest();
222+
expect(findGroupBody(0)).not.toHaveClass('open');
223+
});
214224
});
215225

216226
describe('with dynamic panels', function () {

template/accordion/accordion-group.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ <h4 class="panel-title">
44
<a href tabindex="0" class="accordion-toggle" ng-click="toggleOpen()" accordion-transclude="heading"><span ng-class="{'text-muted': isDisabled}">{{heading}}</span></a>
55
</h4>
66
</div>
7-
<div class="panel-collapse collapse" collapse="!isOpen">
7+
<div class="panel-collapse collapse" collapse="!isOpen" ng-class="{'open': isOpen}">
88
<div class="panel-body" ng-transclude></div>
99
</div>
1010
</div>

0 commit comments

Comments
 (0)