Skip to content

Commit f8db7b0

Browse files
committed
🐛 fix: Fixed #75
1 parent 7298080 commit f8db7b0

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

src/fields/abstractField.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export default {
2525
},
2626

2727
set(newValue) {
28-
2928
if (isFunction(this.formatValueToModel))
3029
newValue = this.formatValueToModel(newValue);
3130

@@ -40,7 +39,7 @@ export default {
4039

4140
watch: {
4241
value: function(newVal, oldVal) {
43-
//console.log("Changed", newVal, oldVal);
42+
// console.log("Changed", newVal, oldVal);
4443
if (isFunction(this.schema.onChanged)) {
4544
this.schema.onChanged(this.model, newVal, oldVal, this.schema);
4645
}

src/fields/fieldNoUiSlider.vue

+1-2
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,8 @@
4747
this.slider.noUiSlider.set(value);
4848
}
4949
},
50-
formatValueToModel() {
50+
formatValueToModel(val) {
5151
if(typeof this.slider.noUiSlider !== "undefined"){
52-
let val = this.slider.noUiSlider.get();
5352
if (val instanceof Array) {
5453
return [Number(val[0]), Number(val[1])];
5554
}else{

test/unit/specs/fields/fieldNoUiSlider.spec.js

+5-7
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,12 @@ describe("fieldNoUiSlider.vue", function() {
5454
}
5555
});
5656

57-
// FIXME: Not working in PhantomJS Left is 0%
58-
it.skip("should contain the value", (done) => {
59-
vm.$nextTick( () => {
57+
it("should contain the value", (done) => {
58+
setTimeout( () => {
6059
let origin = input.querySelector(".noUi-origin");
6160
expect(origin.style.left).to.be.within("70%", "90%");
6261
done();
63-
});
62+
}, 100);
6463
});
6564

6665
it("handle value should be the model value after changed", (done) => {
@@ -72,11 +71,10 @@ describe("fieldNoUiSlider.vue", function() {
7271
}, 100);
7372
});
7473

75-
it.skip("model value should be the handle value after changed", (done) => {
76-
// `field.slider.noUiSlider.set(3);` - It doesn't fired the onChange event
74+
it("model value should be the handle value after changed", (done) => {
7775
field.onChange(3);
7876
setTimeout( () => {
79-
expect(vm.model.rating).to.be.equal(3);
77+
expect(field.model.rating).to.be.equal(3);
8078
done();
8179
}, 100);
8280
});

test/unit/webpack.test.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ var webpack = require("webpack");
33
var sourceDir = path.resolve(__dirname, "../../src");
44

55
module.exports = {
6-
devtool: "#inline-source-map",
6+
devtool: "eval-source-map",
77

88
module: {
99
preLoaders: [

0 commit comments

Comments
 (0)