Skip to content

Commit 01fa81b

Browse files
author
cristian.jora
committed
#112 Get rid of Vue dependency in the code.
Use moment.min to reduce build size
1 parent afe5e74 commit 01fa81b

File tree

7 files changed

+18
-26
lines changed

7 files changed

+18
-26
lines changed

dist/vue-form-generator.js

+10-17
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/fields/fieldDateTimePicker.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<script>
99
/* global $ */
1010
import abstractField from "./abstractField";
11-
import moment from "moment";
11+
import moment from "moment/min/moment.min";
1212
import { defaults } from "lodash";
1313
1414
let inputFormat = "YYYY-MM-DD HH:mm:ss";

src/fields/fieldInput.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
<script>
3939
import abstractField from "./abstractField";
40-
import moment from "moment";
40+
import moment from "moment/min/moment.min";
4141
4242
export default {
4343
mixins: [ abstractField ],

src/fields/fieldPikaday.vue

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
<script>
66
import abstractField from "./abstractField";
7-
import moment from "moment";
7+
import moment from "moment/min/moment.min";
88
import { defaults } from "lodash";
99
1010
let inputFormat = "YYYY-MM-DD";

src/fields/fieldVueMultiSelect.vue

+2-5
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
)
4141
</template>
4242
<script>
43-
import Vue from "vue";
4443
import abstractField from "./abstractField";
4544
4645
export default {
@@ -96,10 +95,8 @@
9695
}
9796
},
9897
created() {
99-
// Check if the component is loaded
100-
if (window.VueMultiselect) {
101-
Vue.component("multiselect", window.VueMultiselect.default ? window.VueMultiselect.default : window.VueMultiselect);
102-
} else {
98+
// Check if the component is loaded globally
99+
if (!this.$root.$options.components["multiselect"]) {
103100
console.error("'vue-multiselect' is missing. Please download from https://github.com/monterail/vue-multiselect and load the script in the HTML head section!");
104101
}
105102
}

src/utils/validators.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { isNil, isNumber, isString, isArray } from "lodash";
2-
import moment from "moment";
2+
import moment from "moment/min/moment.min";
33

44
function checkEmpty(value, required) {
55
if (isNil(value) || value === "") {

test/unit/specs/fields/fieldVueMultiSelect.spec.js

+2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,10 @@ import { createVueField, trigger } from "../util";
33

44
import Vue from "vue";
55
import fieldVueMultiSelect from "src/fields/fieldVueMultiSelect.vue";
6+
import VueMultiSelect from "vue-multiselect";
67

78
Vue.component("fieldVueMultiSelect", fieldVueMultiSelect);
9+
Vue.component("multiselect", VueMultiSelect);
810

911
// eslint-disable-next-line
1012
let el, vm, field;

0 commit comments

Comments
 (0)