Skip to content

Commit 2297661

Browse files
matthijskooijmanianfixes
authored andcommitted
Do not include SPI/Wire from Arduino.h
This is not done on a regular Arduino either, so this needlessly pollutes the namespace and might cause issues in some rare cases. This also changes one testcase that uses SPI to include SPI.h, since it previously relied on Arduino.h to do so.
1 parent 7d7d810 commit 2297661

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Diff for: SampleProjects/TestSomething/test/godmode.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
#include <ArduinoUnitTests.h>
22
#include <Arduino.h>
3+
#include <SPI.h>
34
#include "fibonacciClock.h"
45

56
GodmodeState* state = GODMODE();

Diff for: cpp/arduino/Arduino.h

-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ Where possible, variable names from the Arduino library are used to avoid confli
1414
#include "Print.h"
1515
#include "Stream.h"
1616
#include "HardwareSerial.h"
17-
#include "SPI.h"
18-
#include "Wire.h"
1917

2018
typedef bool boolean;
2119
typedef uint8_t byte;

0 commit comments

Comments
 (0)