You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make template token objects adhere token object structure
While fixing an issue in `eslint-plugin-react`
(jsx-eslint/eslint-plugin-react#1061),
I noticed that template tokens differ from other tokens. A typical token
looks like this:
```
Token {
type: 'String',
value: '"bar"',
start: 44,
end: 49,
loc:
SourceLocation {
start: Position { line: 4, column: 11 },
end: Position { line: 4, column: 16 } },
range: [ 44, 49 ] }
```
A template token looks like this:
```
{ type: 'Template',
value: '`bar`',
loc:
{ start: Position { line: 4, column: 11 },
end: Position { line: 4, column: 16 } },
range: [ 44, 49 ] }
```
I've not be able to figure out why templates are plain JavaScript
objects and not of the class type `Token` (aside from the fact that the
template tokens are constructed differently in the token translator.
This fix copies the `range` values into `start` and `end` properties on
the template tokens to make them adhere to the same structure as other
token objects.
Fixeseslint#319
0 commit comments