Skip to content

Commit 7d44430

Browse files
[Github] Fix TODO after removal of continue on error (llvm#141896)
Previously we were using continue-on-error within the workflows to prevent sending out notifications for workflow failures. We worked around this in the metrics container to see what was actually failing/passing by looking at the individual steps. Now that we have gotten rid of the continue-on-error flag, we just have to look at the job status.
1 parent 62e28d4 commit 7d44430

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

.ci/metrics/metrics.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -349,19 +349,7 @@ def github_get_metrics(
349349
running_count[metric_name] += 1
350350
continue
351351

352-
job_result = int(job.conclusion == "success")
353-
if job_result:
354-
# We still might want to mark the job as a failure if one of the steps
355-
# failed. This is required due to use setting continue-on-error in
356-
# the premerge pipeline to prevent sending emails while we are
357-
# testing the infrastructure.
358-
# TODO(boomanaiden154): Remove this once the premerge pipeline is no
359-
# longer in a testing state and we can directly assert the workflow
360-
# result.
361-
for step in job.steps:
362-
if step.conclusion != "success" and step.conclusion != "skipped":
363-
job_result = 0
364-
break
352+
job_result = int(job.conclusion == "success" or job.conclusion == "skipped")
365353

366354
created_at = job.created_at
367355
started_at = job.started_at

0 commit comments

Comments
 (0)