Skip to content

Commit 95059b3

Browse files
authored
Upgrade to Elasticsearch 8.17.4.
Original Pull Request: spring-projects#3085 Closes spring-projects#3084 Signed-off-by: Peter-Josef Meisch <[email protected]>
1 parent 1ae6301 commit 95059b3

File tree

7 files changed

+8
-36
lines changed

7 files changed

+8
-36
lines changed

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<springdata.commons>3.5.0-SNAPSHOT</springdata.commons>
2222

2323
<!-- version of the ElasticsearchClient -->
24-
<elasticsearch-java>8.17.2</elasticsearch-java>
24+
<elasticsearch-java>8.17.4</elasticsearch-java>
2525

2626
<hoverfly>0.19.0</hoverfly>
2727
<log4j>2.23.1</log4j>

src/main/antora/modules/ROOT/pages/elasticsearch/elasticsearch-new.adoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
[[new-features.5-5-0]]
55
== New in Spring Data Elasticsearch 5.5
66

7-
* Upgrade to Elasticsearch 8.17.2.
7+
* Upgrade to Elasticsearch 8.17.4.
88
* Add support for the `@SearchTemplateQuery` annotation on repository methods.
99
* Scripted field properties of type collection can be populated from scripts returning arrays.
1010

src/main/antora/modules/ROOT/pages/elasticsearch/versions.adoc

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ The following table shows the Elasticsearch and Spring versions that are used by
66
[cols="^,^,^,^",options="header"]
77
|===
88
| Spring Data Release Train | Spring Data Elasticsearch | Elasticsearch | Spring Framework
9-
| 2025.0 (in development) | 5.5.x | 8.17.2 | 6.2.x
9+
| 2025.0 (in development) | 5.5.x | 8.17.4 | 6.2.x
1010
| 2024.1 | 5.4.x | 8.15.5 | 6.1.x
1111
| 2024.0 | 5.3.x | 8.13.4 | 6.1.x
1212
| 2023.1 (Vaughan) | 5.2.xfootnote:oom[Out of maintenance] | 8.11.1 | 6.1.x

src/main/java/org/springframework/data/elasticsearch/client/elc/ResponseConverter.java

-2
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,6 @@ public ReindexResponse reindexResponse(co.elastic.clients.elasticsearch.core.Rei
400400
private ReindexResponse.Failure reindexResponseFailureOf(BulkIndexByScrollFailure failure) {
401401
return ReindexResponse.Failure.builder() //
402402
.withIndex(failure.index()) //
403-
.withType(failure.type()) //
404403
.withId(failure.id()) //
405404
.withStatus(failure.status())//
406405
.withErrorCause(toErrorCause(failure.cause())) //
@@ -411,7 +410,6 @@ private ReindexResponse.Failure reindexResponseFailureOf(BulkIndexByScrollFailur
411410
private ByQueryResponse.Failure byQueryResponseFailureOf(BulkIndexByScrollFailure failure) {
412411
return ByQueryResponse.Failure.builder() //
413412
.withIndex(failure.index()) //
414-
.withType(failure.type()) //
415413
.withId(failure.id()) //
416414
.withStatus(failure.status())//
417415
.withErrorCause(toErrorCause(failure.cause())).build();

src/main/java/org/springframework/data/elasticsearch/core/query/ByQueryResponse.java

+2-15
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ public static ByQueryResponseBuilder builder() {
167167
public static class Failure {
168168

169169
@Nullable private final String index;
170-
@Nullable private final String type;
171170
@Nullable private final String id;
172171
@Nullable private final Exception cause;
173172
@Nullable private final Integer status;
@@ -176,11 +175,10 @@ public static class Failure {
176175
@Nullable private final Boolean aborted;
177176
@Nullable private final ElasticsearchErrorCause elasticsearchErrorCause;
178177

179-
private Failure(@Nullable String index, @Nullable String type, @Nullable String id, @Nullable Exception cause,
178+
private Failure(@Nullable String index, @Nullable String id, @Nullable Exception cause,
180179
@Nullable Integer status, @Nullable Long seqNo, @Nullable Long term, @Nullable Boolean aborted,
181180
@Nullable ElasticsearchErrorCause elasticsearchErrorCause) {
182181
this.index = index;
183-
this.type = type;
184182
this.id = id;
185183
this.cause = cause;
186184
this.status = status;
@@ -195,11 +193,6 @@ public String getIndex() {
195193
return index;
196194
}
197195

198-
@Nullable
199-
public String getType() {
200-
return type;
201-
}
202-
203196
@Nullable
204197
public String getId() {
205198
return id;
@@ -250,7 +243,6 @@ public static FailureBuilder builder() {
250243
*/
251244
public static final class FailureBuilder {
252245
@Nullable private String index;
253-
@Nullable private String type;
254246
@Nullable private String id;
255247
@Nullable private Exception cause;
256248
@Nullable private Integer status;
@@ -266,11 +258,6 @@ public FailureBuilder withIndex(String index) {
266258
return this;
267259
}
268260

269-
public FailureBuilder withType(String type) {
270-
this.type = type;
271-
return this;
272-
}
273-
274261
public FailureBuilder withId(String id) {
275262
this.id = id;
276263
return this;
@@ -307,7 +294,7 @@ public FailureBuilder withErrorCause(ElasticsearchErrorCause elasticsearchErrorC
307294
}
308295

309296
public Failure build() {
310-
return new Failure(index, type, id, cause, status, seqNo, term, aborted, elasticsearchErrorCause);
297+
return new Failure(index, id, cause, status, seqNo, term, aborted, elasticsearchErrorCause);
311298
}
312299
}
313300
}

src/main/java/org/springframework/data/elasticsearch/core/reindex/ReindexResponse.java

+2-15
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ public static ReindexResponseBuilder builder() {
187187
public static class Failure {
188188

189189
@Nullable private final String index;
190-
@Nullable private final String type;
191190
@Nullable private final String id;
192191
@Nullable private final Exception cause;
193192
@Nullable private final Integer status;
@@ -196,11 +195,10 @@ public static class Failure {
196195
@Nullable private final Boolean aborted;
197196
@Nullable private final ElasticsearchErrorCause elasticsearchErrorCause;
198197

199-
private Failure(@Nullable String index, @Nullable String type, @Nullable String id, @Nullable Exception cause,
198+
private Failure(@Nullable String index, @Nullable String id, @Nullable Exception cause,
200199
@Nullable Integer status, @Nullable Long seqNo, @Nullable Long term, @Nullable Boolean aborted,
201200
@Nullable ElasticsearchErrorCause elasticsearchErrorCause) {
202201
this.index = index;
203-
this.type = type;
204202
this.id = id;
205203
this.cause = cause;
206204
this.status = status;
@@ -215,11 +213,6 @@ public String getIndex() {
215213
return index;
216214
}
217215

218-
@Nullable
219-
public String getType() {
220-
return type;
221-
}
222-
223216
@Nullable
224217
public String getId() {
225218
return id;
@@ -269,7 +262,6 @@ public static Failure.FailureBuilder builder() {
269262
*/
270263
public static final class FailureBuilder {
271264
@Nullable private String index;
272-
@Nullable private String type;
273265
@Nullable private String id;
274266
@Nullable private Exception cause;
275267
@Nullable private Integer status;
@@ -285,11 +277,6 @@ public Failure.FailureBuilder withIndex(String index) {
285277
return this;
286278
}
287279

288-
public Failure.FailureBuilder withType(String type) {
289-
this.type = type;
290-
return this;
291-
}
292-
293280
public Failure.FailureBuilder withId(String id) {
294281
this.id = id;
295282
return this;
@@ -326,7 +313,7 @@ public Failure.FailureBuilder withErrorCause(@Nullable ElasticsearchErrorCause e
326313
}
327314

328315
public Failure build() {
329-
return new Failure(index, type, id, cause, status, seqNo, term, aborted, elasticsearchErrorCause);
316+
return new Failure(index, id, cause, status, seqNo, term, aborted, elasticsearchErrorCause);
330317
}
331318
}
332319
}

src/test/resources/testcontainers-elasticsearch.properties

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
#
1616
#
1717
sde.testcontainers.image-name=docker.elastic.co/elasticsearch/elasticsearch
18-
sde.testcontainers.image-version=8.17.2
18+
sde.testcontainers.image-version=8.17.4
1919
#
2020
#
2121
# needed as we do a DELETE /* at the end of the tests, will be required from 8.0 on, produces a warning since 7.13

0 commit comments

Comments
 (0)