Skip to content

Commit b3d7580

Browse files
committed
Update ByoaNet comments. Fix first Steam feat chs for ByobNet.
1 parent 16f7aa9 commit b3d7580

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

timm/models/byoanet.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* Lambda ResNets
99
* HaloNets
1010
11-
Consider all of the models here a WIP and likely to change.
11+
Consider all of the models definitions here as experimental WIP and likely to change.
1212
1313
Hacked together by / copyright Ross Wightman, 2021.
1414
"""
@@ -372,57 +372,59 @@ def _create_byoanet(variant, cfg_variant=None, pretrained=False, **kwargs):
372372

373373
@register_model
374374
def botnet50t_224(pretrained=False, **kwargs):
375-
"""
375+
""" Bottleneck Transformer w/ ResNet50-T backbone. Bottleneck attn in final stage.
376376
"""
377377
kwargs.setdefault('img_size', 224)
378378
return _create_byoanet('botnet50t_224', 'botnet50t', pretrained=pretrained, **kwargs)
379379

380380

381381
@register_model
382382
def botnet50t_c4c5_224(pretrained=False, **kwargs):
383-
"""
383+
""" Bottleneck Transformer w/ ResNet50-T backbone. Bottleneck attn in last two stages.
384384
"""
385385
kwargs.setdefault('img_size', 224)
386386
return _create_byoanet('botnet50t_c4c5_224', 'botnet50t_c4c5', pretrained=pretrained, **kwargs)
387387

388388

389389
@register_model
390390
def halonet_h1(pretrained=False, **kwargs):
391-
"""
391+
""" HaloNet-H1. Halo attention in all stages as per the paper.
392+
393+
This runs very slowly, param count lower than paper --> something is wrong.
392394
"""
393395
return _create_byoanet('halonet_h1', pretrained=pretrained, **kwargs)
394396

395397

396398
@register_model
397399
def halonet_h1_c4c5(pretrained=False, **kwargs):
398-
"""
400+
""" HaloNet-H1 config w/ attention in last two stages.
399401
"""
400402
return _create_byoanet('halonet_h1_c4c5', pretrained=pretrained, **kwargs)
401403

402404

403405
@register_model
404406
def halonet26t(pretrained=False, **kwargs):
405-
"""
407+
""" HaloNet w/ a ResNet26-t backbone, Hallo attention in final stage
406408
"""
407409
return _create_byoanet('halonet26t', pretrained=pretrained, **kwargs)
408410

409411

410412
@register_model
411413
def halonet50t(pretrained=False, **kwargs):
412-
"""
414+
""" HaloNet w/ a ResNet50-t backbone, Hallo attention in final stage
413415
"""
414416
return _create_byoanet('halonet50t', pretrained=pretrained, **kwargs)
415417

416418

417419
@register_model
418420
def lambda_resnet26t(pretrained=False, **kwargs):
419-
"""
421+
""" Lambda-ResNet-26T. Lambda layers in one C4 stage and all C5.
420422
"""
421423
return _create_byoanet('lambda_resnet26t', pretrained=pretrained, **kwargs)
422424

423425

424426
@register_model
425427
def lambda_resnet50t(pretrained=False, **kwargs):
426-
"""
428+
""" Lambda-ResNet-50T. Lambda layers in one C4 stage and all C5.
427429
"""
428430
return _create_byoanet('lambda_resnet50t', pretrained=pretrained, **kwargs)

timm/models/byobnet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,7 +546,7 @@ def __init__(self, in_chs, out_chs, kernel_size=3, stride=4, pool='maxpool',
546546
layer_fn = layers.conv_norm_act if na else create_conv2d
547547
conv_name = f'conv{i + 1}'
548548
if i > 0 and s > 1:
549-
self.feature_info.append(dict(num_chs=ch, reduction=curr_stride, module=prev_feat))
549+
self.feature_info.append(dict(num_chs=prev_chs, reduction=curr_stride, module=prev_feat))
550550
self.add_module(conv_name, layer_fn(prev_chs, ch, kernel_size=kernel_size, stride=s))
551551
prev_chs = ch
552552
curr_stride *= s

0 commit comments

Comments
 (0)