Skip to content

issue with common.urlJoin converting '//' to '/' #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wenjunche opened this issue Oct 7, 2014 · 2 comments
Closed

issue with common.urlJoin converting '//' to '/' #710

wenjunche opened this issue Oct 7, 2014 · 2 comments

Comments

@wenjunche
Copy link

Hello
I just started using this module and really like it.

I am having an issue with following code:
var proxy = httpProxy.createProxyServer({});
proxy.web(req, res, { target: "https://myserver" })
if req.url has something like http://someServer/someService?config=http://server2.com/a.json, the outgoing URL becomes http://someServer/someService?config=http:/server2.com/a.json. I traced the code and it looks like common.urlJoin converts multiple '/' to single '/'. How can I avoid this issue?

Thanks

@odmarkj
Copy link

odmarkj commented Oct 9, 2014

This is what I had to do with the same problem: #703 (comment)

I just commented out the problem line and manually set outgoing.path = outgoingPath

@jcrugzz
Copy link
Contributor

jcrugzz commented Dec 2, 2014

Should be fixed

@jcrugzz jcrugzz closed this as completed Dec 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants