Skip to content

can you update your examples? #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
suzukua opened this issue Sep 24, 2014 · 6 comments
Closed

can you update your examples? #704

suzukua opened this issue Sep 24, 2014 · 6 comments

Comments

@suzukua
Copy link
Contributor

suzukua commented Sep 24, 2014

https://github.com/nodejitsu/node-http-proxy/tree/caronte/examples/middleware

the connect is update to 3.2.0; your examples can not start up!

@indexzero
Copy link
Member

@zhudan those are probably out of date to begin with. We could really use your help updating them :)

@suzukua
Copy link
Contributor Author

suzukua commented Sep 25, 2014

@indexzero when i post a xml body, i want modify this body, but the proxy post the xml is escaped (""" become """), so the content-length header is smaller than the length of body. it's can not post all xml.

the code is this line, https://github.com/nodejitsu/node-http-proxy/blob/caronte/lib/http-proxy/passes/web-incoming.js#L117 ; i modified this line to proxyReq.end(req.rawbody), it's work, but it can not work in all environment.

i really want to know why ? can you tell me? thank you~

@suzukua
Copy link
Contributor Author

suzukua commented Sep 27, 2014

done!

@suzukua suzukua closed this as completed Sep 27, 2014
@indexzero
Copy link
Member

Could you submit a pull request for this change?

@indexzero indexzero reopened this Sep 30, 2014
@suzukua
Copy link
Contributor Author

suzukua commented Oct 8, 2014

@indexzero Ok, i will update later.

@suzukua
Copy link
Contributor Author

suzukua commented Oct 9, 2014

updated. #712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants