Skip to content

changeOrigin support removed in v1.0.0? #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
solidspark opened this issue Sep 11, 2014 · 6 comments
Closed

changeOrigin support removed in v1.0.0? #696

solidspark opened this issue Sep 11, 2014 · 6 comments

Comments

@solidspark
Copy link

Why was changeOrigin removed? It seems like it was killed in the v1.0.0 refactor with no explanation? Changelogs show nothing?

3330e12
@jcrugzz
Copy link
Contributor

jcrugzz commented Sep 12, 2014

@solidspark looking at that functionality, we can totally add that as an option with it defaulted to false. I will most definitely take a pull request 😄

@wclr wclr mentioned this issue Oct 28, 2014
Closed
@wclr
Copy link

wclr commented Oct 28, 2014

This needs to be fixed and its simple.

@indexzero
Copy link
Member

@whitecolor could you submit a simple pull request?

@wclr
Copy link

wclr commented Oct 28, 2014

#722

Well I'm not sure if it is completly correct (it works for me). What about documentation and tests?

@jbender
Copy link

jbender commented Oct 28, 2014

👍 Fork works for me

@jcrugzz
Copy link
Contributor

jcrugzz commented Oct 29, 2014

Fixed with #723

@jcrugzz jcrugzz closed this as completed Oct 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@indexzero @jcrugzz @jbender @wclr @solidspark