Skip to content

closing server econnrefused #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yawnt opened this issue Sep 15, 2013 · 5 comments
Closed

closing server econnrefused #463

yawnt opened this issue Sep 15, 2013 · 5 comments

Comments

@yawnt
Copy link
Contributor

yawnt commented Sep 15, 2013

https://github.com/yawnt/caronte/issues/10

@yawnt
Copy link
Contributor Author

yawnt commented Sep 17, 2013

this should be fixed since error handling is now implemented.. @jcrugzz feel free to reopen if it's not the case

@yawnt yawnt closed this as completed Sep 17, 2013
@jcrugzz jcrugzz reopened this Sep 19, 2013
@jcrugzz
Copy link
Contributor

jcrugzz commented Sep 19, 2013

The following example results in...

/n/j/proxy ❯❯❯ node primus-proxy.js
{ from: 'client', to: 'server' }
disconnected
{ from: 'server', to: 'client' }

/Users/jcrugzz/node.js/nodejitsu/node-http-proxy/lib/caronte/passes/web-incoming.js:108
        throw err;
              ^
Error: connect ECONNREFUSED
    at errnoException (net.js:901:11)
    at Object.afterConnect [as oncomplete] (net.js:892:19)

For one the error should be handled if the EventEmitter2 wildcards are working properly so I have not yet determined if the client will receive the end event (which it should) upon the server being destroyed due to the proxy crashing the process.

cc @yawnt

@jcrugzz jcrugzz mentioned this issue Sep 19, 2013
@jcrugzz
Copy link
Contributor

jcrugzz commented Sep 19, 2013

@cronopio also we should have tests for cases like this for all the various transports as I believe we will hit some edge cases with various disconnects being triggered.

@cronopio
Copy link
Contributor

Ok, @jcrugzz by now there are tests for ws and socket.io and not for primus, I'll try to write it

@jcrugzz
Copy link
Contributor

jcrugzz commented Sep 20, 2013

@cronopio thanks! and make sure the test cases handle when the server closes and the proxy errors. Keep up the good work :)

@yawnt yawnt closed this as completed Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants