websocket proxy not work in node.js version 0.10.0

[llevkin]

a simple test:

var util = require('util'),
http = require('http'),
httpProxy = require('http-proxy');

try {
var io = require('socket.io'),
client = require('socket.io-client');
}
catch (ex) {
console.error('Socket.io is required for this example:');
process.exit(1);
}

//
// Create the target HTTP server and setup
// socket.io on it.
//
var server = io.listen(8080);
server.set('transports', ['websocket']);
server.sockets.on('connection', function (client) {
util.debug('Got websocket connection');

client.on('message', function (msg) {
util.debug('Got message from client: ' + msg);
});
client.send('from server');
});

//
// Create a proxy server with node-http-proxy
//
httpProxy.createServer(8080, 'localhost').listen(8081);

//
// Setup the socket.io client against our proxy
//
var ws = client.connect('ws://localhost:8081');

ws.on('message', function (msg) {
util.debug('Got message: ' + msg);
});

in node.js version 0.10.0 we are never got a message 'Got message: from server'.. In ver. 0.8.18 all work fine..

[truongsinh]

+1, I traceback from LearnBoost's up (depends on LB's distrubute, which in turn depends on NJS's node-http-proxy).
NPM test results in timeout while trying

 ♢ node-http-proxy/routing-proxy/ws-to-ws 

   info  - socket.io started
   debug - client authorized
   info  - handshake authorized izC7UT_NUURZlObaw-EL
   debug - setting request GET /socket.io/1/websocket/Welcome%20to%20socket.io.
   debug - set heartbeat interval for client Welcome%20to%20socket.io.
   debug - websocket writing 7:::1+0
   warn  - client not handshaken client should reconnect
   info  - transport end (error)
   debug - set close timeout for client Welcome%20to%20socket.io.
   debug - cleared close timeout for client Welcome%20to%20socket.io.
   debug - cleared heartbeat interval for client Welcome%20to%20socket.io.
   debug - discarding transport
   debug - setting request GET /socket.io/1/websocket/Welcome%20to%20socket.io.
   debug - set heartbeat interval for client Welcome%20to%20socket.io.
   debug - websocket writing 7:::1+0
   warn  - client not handshaken client should reconnect
   info  - transport end (error)
   debug - set close timeout for client Welcome%20to%20socket.io.
   debug - cleared close timeout for client Welcome%20to%20socket.io.
   debug - cleared heartbeat interval for client Welcome%20to%20socket.io.
   debug - discarding transport

[truongsinh]

anyone?

[llevkin]

nobody cares... =)

[jcrugzz]

Hey guys, we are currently in the process of testing node 0.10.x on our platform. Sometimes the newest versions have some kinks that need to be worked out when our whole system is built on node :). A patch with tests would of course be welcome though!

[desunit]

@jcrugzz is the issue reproducible for you? I have found the same problem.

[indexzero]

Lets call it an issue; someone want to submit a PR?

[pkarc]

It seems it's related to this prev issue:
#97

[indexzero]

Fixed in #402

[glasser]

@indexzero Can you reopen the issue at least, since the fix is buggy as described in #402 (comment) ? (It sometimes double-sends the first chunk of the post-headers part of the proxied websocket data). I know that you said you're planning to do a full rewrite of this code for the 0.10 API but it might be worth keeping open the record of the fact that the current code is buggy...