Skip to content

Routing table always requires a host name #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chiel opened this issue Dec 11, 2012 · 3 comments
Closed

Routing table always requires a host name #350

chiel opened this issue Dec 11, 2012 · 3 comments

Comments

@chiel
Copy link

chiel commented Dec 11, 2012

At the moment when using the router option when using httpProxy.createServer(), each of the entries in that object is required to have a hostname in order to be mapped correctly. It would be awesome if you could map solely based on the path.

If you were to deploy the same code on multiple machines which have slightly different host names, there's not really a way to do this "cleanly" since it's not possible to map based on path alone. Is there any reason this is not allowed at the moment?

I'll see if I can patch it and perhaps send a pull request. In the meantime it would be great to know if there's a specific reason this is currently now allowed.

Thanks

@indexzero
Copy link
Member

Fixed in #380

@Rush
Copy link
Contributor

Rush commented Sep 15, 2013

If this is fixed why not close the issue?

@mmalecki
Copy link
Contributor

Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants