node-http-proxy ignores incoming x-forward-for

[tpetry]

When you build your architecture that node-http-proxy is another proxy in a proxy chain it will ignore the incoming x-forward-for details and set it's own.

Architecture (all on the same server):

[nginx] -> [node-http-proxy] -> [node application]

Expected x-forward-for at node application:

[client-ip], [nginx-ip], [node-http-proxy-ip]

Actual x-forward-for at node application:

[node-http-proxy-ip]

It does not only throw away the x-forward-for information, it even does not pass the proxy-ip in the x-forward-for chain.

[dominictarr]

that definitely sounds more correct.
can you link to an RFC on this or anything?

what x-forward-for does nginx write?

[tpetry]

x-forward-for is a non rfc header, but wikipedia has a very nice article for it. Nginx complies to the description of this article.

[dominictarr]

thanks. I'm gonna do some work on the tests soon, I'll stick this in after that.

[samyakbhuta]

+1 for this issue.

[samyakbhuta]

Please accept the pull request #163.

[AvianFlu]

#163 has been merged; closing issue.