Fixing the if statement as it lead to 'TypeError: Parameter 'url' must be a string, not undefined' in certain cases

subnetmarco · subnetmarco · commit c9b6895c5e14 · 2013-03-14T19:09:03.000-07:00
diff --git a/lib/node-http-proxy/http-proxy.js b/lib/node-http-proxy/http-proxy.js
@@ -268,7 +268,7 @@ HttpProxy.prototype.proxyRequest = function (req, res, buffer) {
       delete response.headers['transfer-encoding'];
     }
 
-    if ((response.statusCode === 301) || (response.statusCode === 302)
+    if ((response.statusCode === 301 || response.statusCode === 302)
       && typeof response.headers.location !== 'undefined') {
       location = url.parse(response.headers.location);
       if (location.host === req.headers.host) {

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ HttpProxy.prototype.proxyRequest = function (req, res, buffer) {`
`268`	`268`	`delete response.headers['transfer-encoding'];`
`269`	`269`	`}`
`270`	`270`
`271`		`- if ((response.statusCode === 301) \|\| (response.statusCode === 302)`
	`271`	`+ if ((response.statusCode === 301 \|\| response.statusCode === 302)`
`272`	`272`	`&& typeof response.headers.location !== 'undefined') {`
`273`	`273`	`location = url.parse(response.headers.location);`
`274`	`274`	`if (location.host === req.headers.host) {`