use regex to check for upgrade header

minrk · minrk · commit 871b06fd5f89 · 2014-09-16T11:15:17.000-07:00
in websocket connections
diff --git a/lib/http-proxy/common.js b/lib/http-proxy/common.js
@@ -53,8 +53,7 @@ common.setupOutgoing = function(outgoing, options, req, forward) {
   if (!outgoing.agent) {
     outgoing.headers = outgoing.headers || {};
     if (typeof outgoing.headers.connection !== 'string'
-        || !outgoing.headers.connection.toLowerCase().split(',').some(
-          function (s) { if (s.trim() === 'upgrade') { return true; } })
+        || !outgoing.headers.connection.match(/(^|,)\s*upgrade\s*($|,)/i)
        ) { outgoing.headers.connection = 'close'; }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,7 @@ common.setupOutgoing = function(outgoing, options, req, forward) {`
`53`	`53`	`if (!outgoing.agent) {`
`54`	`54`	`outgoing.headers = outgoing.headers \|\| {};`
`55`	`55`	`if (typeof outgoing.headers.connection !== 'string'`
`56`		`- \|\| !outgoing.headers.connection.toLowerCase().split(',').some(`
`57`		`- function (s) { if (s.trim() === 'upgrade') { return true; } })`
	`56`	`+ \|\| !outgoing.headers.connection.match(/(^\|,)\supgrade\s($\|,)/i)`
`58`	`57`	`) { outgoing.headers.connection = 'close'; }`
`59`	`58`	`}`
`60`	`59`