Properly write response header optionally including statusMessage (#1061)

ArcanoxDragon · jcrugzz · commit 84087208ddc0 · 2016-09-14T17:08:26.000-04:00
diff --git a/lib/http-proxy/passes/web-outgoing.js b/lib/http-proxy/passes/web-outgoing.js
@@ -108,9 +108,11 @@ var redirectRegex = /^201|30(1|2|7|8)$/;
    * @api private
    */
   function writeStatusCode(req, res, proxyRes) {
-    res.statusCode = proxyRes.statusCode;
+    // From Node.js docs: response.writeHead(statusCode[, statusMessage][, headers])
     if(proxyRes.statusMessage) {
-      res.statusMessage = proxyRes.statusMessage;
+      res.writeHead(proxyRes.statusCode, proxyRes.statusMessage);
+    } else {
+      res.writeHead(proxyRes.statusCode);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,11 @@ var redirectRegex = /^201\|30(1\|2\|7\|8)$/;`
`108`	`108`	`* @api private`
`109`	`109`	`*/`
`110`	`110`	`function writeStatusCode(req, res, proxyRes) {`
`111`		`- res.statusCode = proxyRes.statusCode;`
	`111`	`+ // From Node.js docs: response.writeHead(statusCode[, statusMessage][, headers])`
`112`	`112`	`if(proxyRes.statusMessage) {`
`113`		`- res.statusMessage = proxyRes.statusMessage;`
	`113`	`+ res.writeHead(proxyRes.statusCode, proxyRes.statusMessage);`
	`114`	`+ } else {`
	`115`	`+ res.writeHead(proxyRes.statusCode);`
`114`	`116`	`}`
`115`	`117`	`}`
`116`	`118`