Skip to content

Commit 8251296

Browse files
committed
[dist minor] Removed vendored pool. Changed all references of sys to util
1 parent 00014d6 commit 8251296

12 files changed

+31
-245
lines changed

bin/node-http-proxy

+9-10
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
var path = require('path'),
44
fs = require('fs'),
5-
eyes = require('eyes'),
6-
sys = require('sys'),
5+
util = require('util'),
76
argv = require('optimist').argv,
87
httpProxy = require('./../lib/node-http-proxy');
98

@@ -21,19 +20,14 @@ var help = [
2120
];
2221

2322
if (argv.h || argv.help || Object.keys(argv).length === 2) {
24-
sys.puts(help.join('\n'));
23+
util.puts(help.join('\n'));
2524
process.exit(0);
2625
}
2726

2827
var location, config = {},
2928
port = argv.port || 80,
3029
target = argv.target;
3130

32-
//
33-
// Check to see if we should silence the logs
34-
//
35-
config.silent = argv.silent || false;
36-
3731
//
3832
// If we were passed a config, parse it
3933
//
@@ -42,11 +36,16 @@ if (argv.config) {
4236
var data = fs.readFileSync(argv.config);
4337
config = JSON.parse(data.toString());
4438
} catch (ex) {
45-
sys.puts('Error starting node-http-proxy: ' + ex);
39+
util.puts('Error starting node-http-proxy: ' + ex);
4640
process.exit(1);
4741
}
4842
}
4943

44+
//
45+
// Check to see if we should silence the logs
46+
//
47+
config.silent = typeof argv.silent !== 'undefined' ? argv.silent : config.silent;
48+
5049
//
5150
// If we were passed a target, parse the url string
5251
//
@@ -73,5 +72,5 @@ server.listen(port);
7372
// Notify that the server is started
7473
//
7574
if (!config.silent) {
76-
sys.puts('node-http-proxy server now listening on port: ' + port);
75+
util.puts('node-http-proxy server now listening on port: ' + port);
7776
}

config.sample.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"silent": true,
2+
"silent": false,
33
"router": {
44
"localhost": "localhost:9000"
55
},

demo.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
2525
*/
2626

27-
var sys = require('sys'),
27+
var util = require('util'),
2828
colors = require('colors')
2929
http = require('http'),
3030
httpProxy = require('./lib/node-http-proxy');
@@ -37,24 +37,24 @@ var welcome = '\
3737
# # # # ##### ##### ##### # # ## # \n\
3838
# # # # # # # # # # # # # \n\
3939
# # # # # # # # #### # # # \n';
40-
sys.puts(welcome.rainbow.bold);
40+
util.puts(welcome.rainbow.bold);
4141

4242

4343
//
4444
// Basic Http Proxy Server
4545
//
4646
httpProxy.createServer(9000, 'localhost').listen(8000);
47-
sys.puts('http proxy server'.blue + ' started '.green.bold + 'on port '.blue + '8000'.yellow);
47+
util.puts('http proxy server'.blue + ' started '.green.bold + 'on port '.blue + '8000'.yellow);
4848

4949
//
5050
// Http Proxy Server with Proxy Table
5151
//
5252
httpProxy.createServer({
5353
router: {
54-
'127.0.0.1': 'localhost:9000'
54+
'localhost': 'localhost:9000'
5555
}
5656
}).listen(8001);
57-
sys.puts('http proxy server '.blue + 'started '.green.bold + 'on port '.blue + '8001 '.yellow + 'with proxy table'.magenta.underline)
57+
util.puts('http proxy server '.blue + 'started '.green.bold + 'on port '.blue + '8001 '.yellow + 'with proxy table'.magenta.underline)
5858

5959
//
6060
// Http Proxy Server with Latency
@@ -64,7 +64,7 @@ httpProxy.createServer(function (req, res, proxy) {
6464
proxy.proxyRequest(9000, 'localhost');
6565
}, 200)
6666
}).listen(8002);
67-
sys.puts('http proxy server '.blue + 'started '.green.bold + 'on port '.blue + '8002 '.yellow + 'with latency'.magenta.underline);
67+
util.puts('http proxy server '.blue + 'started '.green.bold + 'on port '.blue + '8002 '.yellow + 'with latency'.magenta.underline);
6868

6969
//
7070
//
@@ -75,7 +75,7 @@ httpProxy.createServer(9000, 'localhost', {
7575
host: 'localhost'
7676
}
7777
}).listen(8003);
78-
sys.puts('http proxy server '.blue + 'started '.green.bold + 'on port '.blue + '8003 '.yellow + 'with forward proxy'.magenta.underline)
78+
util.puts('http proxy server '.blue + 'started '.green.bold + 'on port '.blue + '8003 '.yellow + 'with forward proxy'.magenta.underline)
7979

8080
//
8181
// Http Server with proxyRequest Handler and Latency
@@ -87,7 +87,7 @@ http.createServer(function (req, res) {
8787
proxy.proxyRequest(9000, 'localhost');
8888
}, 200);
8989
}).listen(8004);
90-
sys.puts('http server '.blue + 'started '.green.bold + 'on port '.blue + '8004 '.yellow + 'with proxyRequest handler'.cyan.underline + ' and latency'.magenta);
90+
util.puts('http server '.blue + 'started '.green.bold + 'on port '.blue + '8004 '.yellow + 'with proxyRequest handler'.cyan.underline + ' and latency'.magenta);
9191

9292
//
9393
// Target Http Server
@@ -97,15 +97,15 @@ http.createServer(function (req, res) {
9797
res.write('request successfully proxied to: ' + req.url + '\n' + JSON.stringify(req.headers, true, 2));
9898
res.end();
9999
}).listen(9000);
100-
sys.puts('http server '.blue + 'started '.green.bold + 'on port '.blue + '9000 '.yellow);
100+
util.puts('http server '.blue + 'started '.green.bold + 'on port '.blue + '9000 '.yellow);
101101

102102
//
103103
// Target Http Forwarding Server
104104
//
105105
http.createServer(function (req, res) {
106-
sys.puts('Receiving forward for: ' + req.url)
106+
util.puts('Receiving forward for: ' + req.url)
107107
res.writeHead(200, {'Content-Type': 'text/plain'});
108108
res.write('request successfully forwarded to: ' + req.url + '\n' + JSON.stringify(req.headers, true, 2));
109109
res.end();
110110
}).listen(9001);
111-
sys.puts('http forward server '.blue + 'started '.green.bold + 'on port '.blue + '9001 '.yellow);
111+
util.puts('http forward server '.blue + 'started '.green.bold + 'on port '.blue + '9001 '.yellow);

lib/node-http-proxy.js

+5-6
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@
2424
2525
*/
2626

27-
var sys = require('sys'),
27+
var util = require('util'),
2828
http = require('http'),
29-
eyes = require('eyes'),
3029
events = require('events'),
3130
pool = require('pool'),
3231
ProxyTable = require('./proxy-table').ProxyTable,
@@ -58,7 +57,7 @@ exports.createServer = function () {
5857

5958
router = options.router;
6059
forward = options.forward;
61-
silent = options.silent || true;
60+
silent = typeof options.silent !== 'undefined' ? options.silent : true;
6261

6362
if (router) {
6463
proxyTable = new ProxyTable(router, options.silent);
@@ -70,17 +69,17 @@ exports.createServer = function () {
7069
var server = http.createServer(function (req, res) {
7170
function log (message) {
7271
if (!silent) {
73-
sys.log(message);
72+
util.log(message);
7473
}
7574
}
7675

7776
var proxy = new HttpProxy(req, res);
7877
log('Incoming HTTP request to: ' + req.headers.host + req.url);
7978

8079
if (forward) {
81-
var forward = new HttpProxy(req, res);
80+
var forwardProxy = new HttpProxy(req, res);
8281
log('Forwarding HTTP request to: ' + forward.host + ':' + forward.port);
83-
forward.forwardRequest(forward.port, forward.host);
82+
forwardProxy.forwardRequest(forward.port, forward.host);
8483
}
8584

8685
// If we were passed a callback to process the request

lib/proxy-table.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ var util = require('util'),
3030

3131
var ProxyTable = function (router, silent) {
3232
events.EventEmitter.call(this);
33-
this.silent = silent || true;
33+
this.silent = typeof silent !== 'undefined' ? silent : true;
3434

3535
if (typeof router === 'object') {
3636
// If we are passed an object literal setup

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"vows": ">= 0.5.2"
2121
},
2222
"main": "./lib/node-http-proxy",
23-
"bin": { "http-proxy": "./bin/node-http-proxy" },
23+
"bin": { "node-http-proxy": "./bin/node-http-proxy" },
2424
"scripts": { "test": "vows test/*-test.js --spec" },
2525
"engines": { "node": ">= 0.3.0" }
2626
}

test/forward-proxy-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
var fs = require('fs'),
99
vows = require('vows'),
10-
sys = require('sys'),
10+
util = require('util'),
1111
path = require('path'),
1212
request = require('request'),
1313
assert = require('assert'),

test/node-http-proxy-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
*/
2626

2727
var vows = require('vows'),
28-
sys = require('sys'),
28+
util = require('util'),
2929
request = require('request'),
3030
assert = require('assert'),
3131
helpers = require('./helpers'),

test/proxy-table-test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
var fs = require('fs'),
99
vows = require('vows'),
10-
sys = require('sys'),
10+
util = require('util'),
1111
path = require('path'),
1212
request = require('request'),
1313
assert = require('assert'),

vendor/pool/README.md

-41
This file was deleted.

0 commit comments

Comments
 (0)