Sanitize header keys before setting them (#997)

randunel · jcrugzz · commit 284903d37961 · 2016-04-26T13:26:35.000-07:00
Fixes #996.
diff --git a/lib/http-proxy/passes/web-outgoing.js b/lib/http-proxy/passes/web-outgoing.js
@@ -83,7 +83,7 @@ var redirectRegex = /^30(1|2|7|8)$/;
   function writeHeaders(req, res, proxyRes) {
     Object.keys(proxyRes.headers).forEach(function(key) {
       if(proxyRes.headers[key] != undefined){
-        res.setHeader(key, proxyRes.headers[key]);
+        res.setHeader(String(key).trim(), proxyRes.headers[key]);
       }
     });
   },

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ var redirectRegex = /^30(1\|2\|7\|8)$/;`
`83`	`83`	`function writeHeaders(req, res, proxyRes) {`
`84`	`84`	`Object.keys(proxyRes.headers).forEach(function(key) {`
`85`	`85`	`if(proxyRes.headers[key] != undefined){`
`86`		`- res.setHeader(key, proxyRes.headers[key]);`
	`86`	`+ res.setHeader(String(key).trim(), proxyRes.headers[key]);`
`87`	`87`	`}`
`88`	`88`	`});`
`89`	`89`	`},`