[fix] Ensure response.headers.location is defined. Fixes #276.

indexzero · indexzero · commit 013cb2e0c208 · 2013-03-09T00:28:50.000-05:00
diff --git a/lib/node-http-proxy/http-proxy.js b/lib/node-http-proxy/http-proxy.js
@@ -247,7 +247,8 @@ HttpProxy.prototype.proxyRequest = function (req, res, buffer) {
       delete response.headers['transfer-encoding'];
     }
 
-    if ((response.statusCode === 301) || (response.statusCode === 302)) {
+    if ((response.statusCode === 301) || (response.statusCode === 302)
+      && typeof response.headers.location !== 'undefined') {
       if (self.source.https && !self.target.https) {
         response.headers.location = response.headers.location.replace(/^http\:/, 'https:');
       }

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,8 @@ HttpProxy.prototype.proxyRequest = function (req, res, buffer) {`
`247`	`247`	`delete response.headers['transfer-encoding'];`
`248`	`248`	`}`
`249`	`249`
`250`		`- if ((response.statusCode === 301) \|\| (response.statusCode === 302)) {`
	`250`	`+ if ((response.statusCode === 301) \|\| (response.statusCode === 302)`
	`251`	`+ && typeof response.headers.location !== 'undefined') {`
`251`	`252`	`if (self.source.https && !self.target.https) {`
`252`	`253`	`response.headers.location = response.headers.location.replace(/^http\:/, 'https:');`
`253`	`254`	`}`