-
Notifications
You must be signed in to change notification settings - Fork 294
Drop six 1.9 support #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I wonder if this isn't related to Travis, but rather that we don't specify which version of pytest to install and use: https://github.com/html5lib/html5lib-python/blob/master/requirements-test.txt#L4 I forget if that file affects what gets installed, but can look into it in a couple of hours or tomorrow. |
Whatever the cause, this is no longer happening, the 3.6 env is passing on Travis (and all of them: 2.7, 3.5-3.8, PyPy and PyPy3). Latest master build: Edit: the issue appeared in pytest 3.3.0, and was fixed by pinning Can this issue now be closed? In case you do want to bump to six 1.10, here's a passing branch I can PR: |
Currently html5lib works with six 1.9+, including the latest 1.16.0 (example: https://ci.appveyor.com/project/gsnedders/html5lib-python/builds/46378000/job/kfed1o7y9uw02q9i). We can close this. |
The version of
pytest
on Travis's 3.6 environment seems to rely onsix>=1.10
so oursix==1.9
test config fails. See, e.g., https://travis-ci.org/html5lib/html5lib-python/jobs/308631931Given 1.10 is now over two years old, I'd hope we can drop support for 1.9, and fix this by just bumping our min required version to 1.10.
The text was updated successfully, but these errors were encountered: