Skip to content

Drop six 1.9 support #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gsnedders opened this issue Nov 28, 2017 · 4 comments
Closed

Drop six 1.9 support #370

gsnedders opened this issue Nov 28, 2017 · 4 comments

Comments

@gsnedders
Copy link
Member

The version of pytest on Travis's 3.6 environment seems to rely on six>=1.10 so our six==1.9 test config fails. See, e.g., https://travis-ci.org/html5lib/html5lib-python/jobs/308631931

Given 1.10 is now over two years old, I'd hope we can drop support for 1.9, and fix this by just bumping our min required version to 1.10.

@gsnedders
Copy link
Member Author

(see #301, #298 for the 1.9 requirement)

@willkg
Copy link
Contributor

willkg commented Nov 28, 2017

I wonder if this isn't related to Travis, but rather that we don't specify which version of pytest to install and use:

https://github.com/html5lib/html5lib-python/blob/master/requirements-test.txt#L4

I forget if that file affects what gets installed, but can look into it in a couple of hours or tomorrow.

@hugovk
Copy link
Contributor

hugovk commented Feb 26, 2020

Whatever the cause, this is no longer happening, the 3.6 env is passing on Travis (and all of them: 2.7, 3.5-3.8, PyPy and PyPy3).

Latest master build:

Edit: the issue appeared in pytest 3.3.0, and was fixed by pinning pytest==3.2.5 in #364.

Can this issue now be closed?


In case you do want to bump to six 1.10, here's a passing branch I can PR:

(And #429 and #441 will bump to latest pytest 5.)

@ambv
Copy link
Member

ambv commented Mar 1, 2023

Currently html5lib works with six 1.9+, including the latest 1.16.0 (example: https://ci.appveyor.com/project/gsnedders/html5lib-python/builds/46378000/job/kfed1o7y9uw02q9i). We can close this.

@ambv ambv closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants