VE.Direct: prefer strncpy over strcpy

schlimmchen · schlimmchen · commit 63370e8a831a · 2024-05-31T20:16:29.000+02:00
strcpy is not safe.
diff --git a/lib/VeDirectFrameHandler/VeDirectFrameHandler.cpp b/lib/VeDirectFrameHandler/VeDirectFrameHandler.cpp
@@ -242,12 +242,12 @@ void VeDirectFrameHandler<T>::processTextData(std::string const& name, std::stri
 	}
 
 	if (name == "SER") {
-		strcpy(_tmpFrame.serialNr_SER, value.c_str());
+		strncpy(_tmpFrame.serialNr_SER, value.c_str(), sizeof(_tmpFrame.serialNr_SER));
 		return;
 	}
 
 	if (name == "FW") {
-		strcpy(_tmpFrame.firmwareVer_FW, value.c_str());
+		strncpy(_tmpFrame.firmwareVer_FW, value.c_str(), sizeof(_tmpFrame.firmwareVer_FW));
 		return;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -242,12 +242,12 @@ void VeDirectFrameHandler<T>::processTextData(std::string const& name, std::stri`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`if (name == "SER") {`
`245`		`- strcpy(_tmpFrame.serialNr_SER, value.c_str());`
	`245`	`+ strncpy(_tmpFrame.serialNr_SER, value.c_str(), sizeof(_tmpFrame.serialNr_SER));`
`246`	`246`	`return;`
`247`	`247`	`}`
`248`	`248`
`249`	`249`	`if (name == "FW") {`
`250`		`- strcpy(_tmpFrame.firmwareVer_FW, value.c_str());`
	`250`	`+ strncpy(_tmpFrame.firmwareVer_FW, value.c_str(), sizeof(_tmpFrame.firmwareVer_FW));`
`251`	`251`	`return;`
`252`	`252`	`}`
`253`	`253`