Fixed that everyting with empt is invalid

Author: horejsek

CHANGELOG.txt

@@ -3,6 +3,7 @@
 * Updated test suite
 * Fixed detecting when infinity is reached with multipleOf
 * Fixed that min/max items/lenght/properties can be float
+* Fixed that everything with empty `not` is invalid
 
 === 2.20.0 (2024-06-15)
 

Makefile

@@ -29,7 +29,7 @@ jsonschemasuitcases:
 	git submodule update
 
 test: venv jsonschemasuitcases
-	${PYTHON} -m pytest -W default --benchmark-skip
+	${PYTHON} -m pytest -W default --benchmark-skip #tests/json_schema/test_draft07.py
 test-lf: venv jsonschemasuitcases
 	${PYTHON} -m pytest -W default --benchmark-skip --last-failed
 

fastjsonschema/draft04.py

@@ -211,8 +211,7 @@ def generate_not(self):
         elif not_definition is False:
             return
         elif not not_definition:
-            with self.l('if {}:', self._variable):
-                self.exc('{name} must NOT match a disallowed definition', rule='not')
+            self.exc('{name} must NOT match a disallowed definition', rule='not')
         else:
             with self.l('try:', optimize=False):
                 self.generate_func_code_block(not_definition, self._variable, self._variable_name)

tests/json_schema/test_draft04.py

@@ -19,9 +19,6 @@ def pytest_generate_tests(metafunc):
             'const.json',
             'enum.json',
 
-            # TODO: fix empty schema == invalid
-            'not.json',
-
             # TODO: fix formats
             'email.json',
             'date-time.json',

tests/json_schema/test_draft06.py

@@ -19,9 +19,6 @@ def pytest_generate_tests(metafunc):
             'const.json',
             'enum.json',
 
-            # TODO: fix empty schema == invalid
-            'not.json',
-
             # TODO: fix formats
             'email.json',
             'date-time.json',

tests/json_schema/test_draft07.py

@@ -21,9 +21,6 @@ def pytest_generate_tests(metafunc):
             'const.json',
             'enum.json',
 
-            # TODO: fix empty schema == invalid
-            'not.json',
-
             # TODO: fix formats
             'email.json',
             'date-time.json',

tests/json_schema/test_draft2019.py

@@ -21,9 +21,6 @@ def pytest_generate_tests(metafunc):
             'const.json',
             'enum.json',
 
-            # TODO: fix empty schema == invalid
-            'not.json',
-
             # TODO: fix formats
             'email.json',
             'date-time.json',
@@ -42,6 +39,7 @@ def pytest_generate_tests(metafunc):
             'definitions.json',
 
             # TODO: new stuff, not implemented yet
+            'not.json',
             'anchor.json',
             'content.json',
             'defs.json',