Prematurely update test_full_like for proposed spec change

See data-apis/array-api#274

Author: honno

.github/workflows/numpy.yml

@@ -51,9 +51,6 @@ jobs:
             "array_api_tests/test_signatures.py::test_function_positional_args[__index__]",
             "array_api_tests/test_signatures.py::test_function_keyword_only_args[prod]",
             "array_api_tests/test_signatures.py::test_function_keyword_only_args[sum]",
-
-            # https://github.com/data-apis/array-api-tests/pull/18#discussion_r715047213
-            "array_api_tests/test_creation_functions.py::test_full_like"
         )
 
         def pytest_collection_modifyitems(config, items):

array_api_tests/test_creation_functions.py

@@ -1,16 +1,14 @@
-from hypothesis.strategies._internal.core import sampled_from
 from ._array_module import (asarray, arange, ceil, empty, empty_like, eye, full,
                             full_like, equal, all, linspace, ones, ones_like,
                             zeros, zeros_like, isnan)
-from . import _array_module as xp
 from .array_helpers import (is_integer_dtype, dtype_ranges,
                             assert_exactly_equal, isintegral, is_float_dtype)
 from .hypothesis_helpers import (numeric_dtypes, dtypes, MAX_ARRAY_SIZE,
                                  shapes, sizes, sqrt_sizes, shared_dtypes,
                                  scalars, xps)
 
 from hypothesis import assume, given
-from hypothesis.strategies import integers, floats, one_of, none, booleans, just, shared, composite
+from hypothesis.strategies import integers, floats, one_of, none, booleans, just, shared
 
 
 optional_dtypes = none() | shared_dtypes
@@ -157,34 +155,19 @@ def test_full(shape, fill_value, dtype):
     else:
         assert all(equal(a, asarray(fill_value, **kwargs))), "full() array did not equal the fill value"
 
-@composite
-def fill_values(draw):
-    # If dtype has been specified, fill_value should be inferred from it
-    dtype = draw(shared_optional_dtypes)
-    # If dtype=None, fill_value can be anything - full_like should infer the dtype
-    if dtype is None:
-        dtype = draw(sampled_from([xp.bool, xp.int32, xp.float32]))
-    return draw(xps.from_dtype(dtype))
 
 @given(
     x=xps.arrays(dtype=shared_dtypes, shape=shapes),
-    fill_value=fill_values(),
+    fill_value=shared_dtypes.flatmap(xps.from_dtype),
     dtype=shared_optional_dtypes,
 )
 def test_full_like(x, fill_value, dtype):
     x_like = full_like(x, fill_value, dtype=dtype)
 
     if dtype is None:
-        if isinstance(fill_value, bool):
-            assert x_like.dtype == xp.bool, f"{fill_value=}, but full_like() did not produce a boolean array - instead was {x_like.dtype}"
-        elif isinstance(fill_value, int):
-            assert x_like.dtype in (xp.int32, xp.int64), f"{fill_value=}, but full_like() did not produce a int32 or int64 array - instead was {x_like.dtype}"
-        elif isinstance(fill_value, float):
-            assert x_like.dtype in (xp.float32, xp.float64), f"{fill_value=}, but full_like() did not produce a float32 or float64 array - instead was {x_like.dtype}"
-        else:
-            raise Exception(f"Sanity check failed, indiciating a bug in the test suite. {fill_value=} - should be a bool, int or float")
+        assert x_like.dtype == x.dtype, f"{x.dtype=}, but full_like() did not produce a {x.dtype} array - instead was {x_like.dtype}"
     else:
-        assert x_like.dtype == dtype
+        assert x_like.dtype == None, f"{dtype=}, but full_like() did not produce a {dtype} array - instead was {x_like.dtype}"
 
     assert x_like.shape == x.shape, "full_like() produced an array with incorrect shape"
     if is_float_dtype(x_like.dtype) and isnan(asarray(fill_value)):