Skip to content

Commit 52ca956

Browse files
committed
Fix compile on Mac OS 10.14 with Python 3.6. See pandas-dev/pandas#23424
1 parent 1db919b commit 52ca956

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

setup.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,18 @@
4646
# compile with: python setup.py build_ext -i
4747
# clean up with: python setup.py clean --all
4848
if sys.platform == 'darwin':
49-
extra_compiler_args = ['-stdlib=libc++']
49+
# see https://github.com/pandas-dev/pandas/issues/23424
50+
extra_compiler_args = ['-stdlib=libc++'] # not needed #, '-mmacosx-version-min=10.9']
5051
else:
5152
extra_compiler_args = []
5253

5354
ext_modules = [Extension("caiman.source_extraction.cnmf.oasis",
5455
sources=["caiman/source_extraction/cnmf/oasis.pyx"],
5556
include_dirs=[np.get_include()],
5657
language="c++",
57-
extra_compile_args = extra_compiler_args)]
58+
extra_compile_args = extra_compiler_args,
59+
extra_link_args = extra_compiler_args,
60+
)]
5861

5962
setup(
6063
name='caiman',

0 commit comments

Comments
 (0)