Skip to content

Need to abort/rollback transactions on error #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sanne opened this issue Mar 14, 2023 · 0 comments · Fixed by #2123
Closed

Need to abort/rollback transactions on error #1514

Sanne opened this issue Mar 14, 2023 · 0 comments · Fixed by #2123
Assignees
@DavideD
Labels
bug Something isn't working
Milestone
3.0.0.Beta2

Comments

@Sanne
Copy link
Member

Sanne commented Mar 14, 2023

It would seem that if I introduce assertions to check that the current transaction is terminated (in any way) before we close the connection, there's at least one test failing:
"ReactiveStatelessProxyUpdateTest. testLazyInitializationException"

We need to investigate this to ensure such resources don't leak under any circumstances.

Providing a test as a PR soon
@Sanne Sanne added bug Something isn't working Hibernate Reactive 2.0 labels Mar 14, 2023
@Sanne Sanne mentioned this issue Mar 14, 2023
Closed
@DavideD DavideD self-assigned this Feb 17, 2025
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Add test to ReactiveStatelessProxyUpdateTest
c7afdaf 
We need to test with Mutiny and with CompletionStage because
the exception is thrown by the API classes.

I've also cleaned up a bit the code to avoid NullPointerException
in case of failures (it should throw the correct assertion error).
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Test lazy exception with transaction
d63f77c
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Catch errors thrown while executing a transactions
4a997c5 
Before, we were ignoring some errors if they were happening
in the worker provided to the transactions.
Because of this, the transaction wasn't always rollbacked or
closed.
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@Sanne @DavideD
[hibernate#1514] Hardening of current transaction state
ea2a93d
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
Revert "[hibernate#1514] Catch errors thrown while executing a transa…
4303f09 
…ctions"

This reverts commit 4a997c5.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Add test to ReactiveStatelessProxyUpdateTest
01bb304 
We need to test with Mutiny and with CompletionStage because
the exception is thrown by the API classes.

I've also cleaned up a bit the code to avoid NullPointerException
in case of failures (it should throw the correct assertion error).
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Test lazy exception with transaction
40ad188
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Catch errors thrown while executing a transactions
e1eb8c9 
Before, we were ignoring some errors if they were happening
in the worker provided to the transactions.
Because of this, the transaction wasn't always rollbacked or
closed.
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@Sanne @DavideD
[hibernate#1514] Hardening of current transaction state
abc2852
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Add test to ReactiveStatelessProxyUpdateTest
3cd4d3a 
We need to test with Mutiny and with CompletionStage because
the exception is thrown by the API classes.

I've also cleaned up a bit the code to avoid NullPointerException
in case of failures (it should throw the correct assertion error).
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Test lazy exception with transaction
98e4894
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@DavideD
[hibernate#1514] Catch errors thrown while executing a transactions
25c3149 
Before, we were ignoring some errors if they were happening
in the worker provided to the transactions.
Because of this, the transaction wasn't always rollbacked or
closed.
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Feb 17, 2025
@Sanne @DavideD
[hibernate#1514] Hardening of current transaction state
b62e6f6
@DavideD DavideD mentioned this issue Feb 17, 2025
Merged
DavideD added a commit that referenced this issue Feb 17, 2025
@DavideD
[#1514] Add test to ReactiveStatelessProxyUpdateTest
2ae7ceb 
We need to test with Mutiny and with CompletionStage because
the exception is thrown by the API classes.

I've also cleaned up a bit the code to avoid NullPointerException
in case of failures (it should throw the correct assertion error).
DavideD added a commit that referenced this issue Feb 17, 2025
@DavideD
[#1514] Test lazy exception with transaction
2fe3e4a
DavideD added a commit that referenced this issue Feb 17, 2025
@DavideD
[#1514] Catch errors thrown while executing a transactions
0861b89 
Before, we were ignoring some errors if they were happening
in the worker provided to the transactions.
Because of this, the transaction wasn't always rollbacked or
closed.
DavideD pushed a commit that referenced this issue Feb 17, 2025
@Sanne @DavideD
[#1514] Hardening of current transaction state
beeae17
@DavideD DavideD added this to the 3.0.0.Beta2 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0.Beta2
Development

Successfully merging a pull request may close this issue.

Hardening transaction state DavideD/hibernate-reactive
2 participants
@Sanne @DavideD