HHH-18410 Make use of getter/setter cache as much as possible

Author: beikov

hibernate-core/src/main/java/org/hibernate/action/internal/AbstractEntityInsertAction.java

@@ -182,14 +182,14 @@ private void visitEmbeddedAttributeMapping(
 				if ( attribute.isPluralAttributeMapping() ) {
 					addCollectionKey(
 							attribute.asPluralAttributeMapping(),
-							descriptor.getValue( object, i ),
+							attribute.getValue( object ),
 							persistenceContext
 					);
 				}
 				else if ( attribute.isEmbeddedAttributeMapping() ) {
 					visitEmbeddedAttributeMapping(
 							attribute.asEmbeddedAttributeMapping(),
-							descriptor.getValue( object, i ),
+							attribute.getValue( object ),
 							persistenceContext
 					);
 				}

hibernate-core/src/main/java/org/hibernate/engine/internal/StatefulPersistenceContext.java

@@ -412,7 +412,7 @@ public EntityHolder claimEntityHolderIfPossible(
 	}
 
 	@Override
-	public @Nullable EntityHolderImpl getEntityHolder(EntityKey key) {
+	public EntityHolderImpl getEntityHolder(EntityKey key) {
 		return entitiesByKey == null ? null : entitiesByKey.get( key );
 	}
 
@@ -525,7 +525,7 @@ public Object removeEntity(EntityKey key) {
 	}
 
 	@Override
-	public @Nullable EntityHolderImpl removeEntityHolder(EntityKey key) {
+	public EntityHolderImpl removeEntityHolder(EntityKey key) {
 		final EntityHolderImpl holder;
 		if ( entitiesByKey != null ) {
 			holder = entitiesByKey.remove( key );
@@ -1316,7 +1316,7 @@ public int getNumberOfManagedEntities() {
 	 */
 	@Override
 	@Deprecated
-	public @Nullable Map<PersistentCollection<?>,CollectionEntry> getCollectionEntries() {
+	public Map<PersistentCollection<?>,CollectionEntry> getCollectionEntries() {
 		return collectionEntries;
 	}
 

hibernate-core/src/main/java/org/hibernate/type/ComponentType.java

@@ -398,18 +398,7 @@ else if ( component instanceof Object[] ) {
 			return ((Object[]) component)[i];
 		}
 		else {
-			final EmbeddableMappingType embeddableMappingType = embeddableTypeDescriptor();
-			if ( embeddableMappingType.isPolymorphic() ) {
-				final EmbeddableMappingType.ConcreteEmbeddableType concreteEmbeddableType = embeddableMappingType.findSubtypeBySubclass(
-						component.getClass().getName()
-				);
-				return concreteEmbeddableType.declaresAttribute( i )
-						? embeddableMappingType.getValue( component, i )
-						: null;
-			}
-			else {
-				return embeddableMappingType.getValue( component, i );
-			}
+			return embeddableTypeDescriptor().getValue( component, i );
 		}
 	}