Skip to content

Commit 6c62b81

Browse files
gavinkinggavinking
committed
add missing @deprecated and @OverRide annotations
side effect of TemporalType deprecation in spec
1 parent f2cec1c commit 6c62b81

19 files changed

+183
-162
lines changed

‎hibernate-core/src/main/java/org/hibernate/procedure/ProcedureCall.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -255,28 +255,28 @@ default void close() {
255255
@Override
256256
<T> ProcedureCall setParameter( Parameter<T> param, T value);
257257

258-
@Override
258+
@Override @Deprecated
259259
ProcedureCall setParameter(Parameter<Calendar> param, Calendar value, TemporalType temporalType);
260260

261-
@Override
261+
@Override @Deprecated
262262
ProcedureCall setParameter(Parameter<Date> param, Date value, TemporalType temporalType);
263263

264264
@Override
265265
ProcedureCall setParameter(String name, Object value);
266266

267-
@Override
267+
@Override @Deprecated
268268
ProcedureCall setParameter(String name, Calendar value, TemporalType temporalType);
269269

270-
@Override
270+
@Override @Deprecated
271271
ProcedureCall setParameter(String name, Date value, TemporalType temporalType);
272272

273273
@Override
274274
ProcedureCall setParameter(int position, Object value);
275275

276-
@Override
276+
@Override @Deprecated
277277
ProcedureCall setParameter(int position, Calendar value, TemporalType temporalType);
278278

279-
@Override
279+
@Override @Deprecated
280280
ProcedureCall setParameter(int position, Date value, TemporalType temporalType);
281281

282282
@Override @Deprecated(since = "7")

‎hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureCallImpl.java

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,6 @@
7878
import org.hibernate.type.BasicTypeReference;
7979
import org.hibernate.type.spi.TypeConfiguration;
8080

81-
import org.jboss.logging.Logger;
82-
8381
import jakarta.persistence.CacheRetrieveMode;
8482
import jakarta.persistence.CacheStoreMode;
8583
import jakarta.persistence.FlushModeType;
@@ -107,7 +105,6 @@
107105
public class ProcedureCallImpl<R>
108106
extends AbstractQuery<R>
109107
implements ProcedureCallImplementor<R>, ResultContext {
110-
private static final Logger LOG = Logger.getLogger( ProcedureCallImpl.class );
111108

112109
private final String procedureName;
113110

@@ -656,7 +653,6 @@ private ProcedureOutputsImpl buildOutputs() {
656653
}
657654
}
658655

659-
LOG.debugf( "Preparing procedure call : %s", call);
660656
final String sqlString = call.getSqlString();
661657
final CallableStatement statement = (CallableStatement) getSession()
662658
.getJdbcCoordinator()
@@ -1207,7 +1203,7 @@ public <P> ProcedureCallImplementor<R> setParameter(int position, P value, Binda
12071203
return this;
12081204
}
12091205

1210-
@Override
1206+
@Override @Deprecated
12111207
public ProcedureCallImplementor<R> setParameter(
12121208
Parameter<Calendar> parameter,
12131209
Calendar value,
@@ -1216,31 +1212,31 @@ public ProcedureCallImplementor<R> setParameter(
12161212
return this;
12171213
}
12181214

1219-
@Override
1215+
@Override @Deprecated
12201216
public ProcedureCallImplementor<R> setParameter(Parameter<Date> parameter, Date value, TemporalType temporalPrecision) {
12211217
super.setParameter( parameter, value, temporalPrecision );
12221218
return this;
12231219
}
12241220

1225-
@Override
1221+
@Override @Deprecated
12261222
public ProcedureCallImplementor<R> setParameter(String name, Calendar value, TemporalType temporalPrecision) {
12271223
super.setParameter( name, value, temporalPrecision );
12281224
return this;
12291225
}
12301226

1231-
@Override
1227+
@Override @Deprecated
12321228
public ProcedureCallImplementor<R> setParameter(String name, Date value, TemporalType temporalPrecision) {
12331229
super.setParameter( name, value, temporalPrecision );
12341230
return this;
12351231
}
12361232

1237-
@Override
1233+
@Override @Deprecated
12381234
public ProcedureCallImplementor<R> setParameter(int position, Calendar value, TemporalType temporalPrecision) {
12391235
super.setParameter( position, value, temporalPrecision );
12401236
return this;
12411237
}
12421238

1243-
@Override
1239+
@Override @Deprecated
12441240
public ProcedureCallImplementor<R> setParameter(int position, Date value, TemporalType temporalPrecision) {
12451241
super.setParameter( position, value, temporalPrecision );
12461242
return this;

‎hibernate-core/src/main/java/org/hibernate/procedure/spi/ProcedureCallImplementor.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,28 +51,28 @@ default List<R> getResultList() {
5151
@Override
5252
<T> ProcedureCallImplementor<R> setParameter(Parameter<T> param, T value);
5353

54-
@Override
54+
@Override @Deprecated
5555
ProcedureCallImplementor<R> setParameter(Parameter<Calendar> param, Calendar value, TemporalType temporalType);
5656

57-
@Override
57+
@Override @Deprecated
5858
ProcedureCallImplementor<R> setParameter(Parameter<Date> param, Date value, TemporalType temporalType);
5959

6060
@Override
6161
ProcedureCallImplementor<R> setParameter(String name, Object value);
6262

63-
@Override
63+
@Override @Deprecated
6464
ProcedureCallImplementor<R> setParameter(String name, Calendar value, TemporalType temporalType);
6565

66-
@Override
66+
@Override @Deprecated
6767
ProcedureCallImplementor<R> setParameter(String name, Date value, TemporalType temporalType);
6868

6969
@Override
7070
ProcedureCallImplementor<R> setParameter(int position, Object value);
7171

72-
@Override
72+
@Override @Deprecated
7373
ProcedureCallImplementor<R> setParameter(int position, Calendar value, TemporalType temporalType);
7474

75-
@Override
75+
@Override @Deprecated
7676
ProcedureCallImplementor<R> setParameter(int position, Date value, TemporalType temporalType);
7777

7878
@Override

‎hibernate-core/src/main/java/org/hibernate/query/CommonQueryContract.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -222,17 +222,26 @@ public interface CommonQueryContract {
222222
/**
223223
* Bind an {@link Instant} to the named query parameter using just the
224224
* portion indicated by the given {@link TemporalType}.
225+
*
226+
* @deprecated since {@link TemporalType} is deprecated
225227
*/
228+
@Deprecated(since = "7")
226229
CommonQueryContract setParameter(String parameter, Instant value, TemporalType temporalType);
227230

228231
/**
229232
* @see jakarta.persistence.Query#setParameter(String, Calendar, TemporalType)
233+
*
234+
* @deprecated since {@link TemporalType} is deprecated
230235
*/
236+
@Deprecated(since = "7")
231237
CommonQueryContract setParameter(String parameter, Calendar value, TemporalType temporalType);
232238

233239
/**
234240
* @see jakarta.persistence.Query#setParameter(String, Date, TemporalType)
241+
*
242+
* @deprecated since {@link TemporalType} is deprecated
235243
*/
244+
@Deprecated(since = "7")
236245
CommonQueryContract setParameter(String parameter, Date value, TemporalType temporalType);
237246

238247
/**
@@ -265,17 +274,26 @@ public interface CommonQueryContract {
265274
/**
266275
* Bind an {@link Instant} to an ordinal query parameter using just the
267276
* portion indicated by the given {@link TemporalType}.
277+
*
278+
* @deprecated since {@link TemporalType} is deprecated
268279
*/
280+
@Deprecated(since = "7")
269281
CommonQueryContract setParameter(int parameter, Instant value, TemporalType temporalType);
270282

271283
/**
272284
* @see jakarta.persistence.Query#setParameter(int, Date, TemporalType)
285+
*
286+
* @deprecated since {@link TemporalType} is deprecated
273287
*/
288+
@Deprecated(since = "7")
274289
CommonQueryContract setParameter(int parameter, Date value, TemporalType temporalType);
275290

276291
/**
277292
* @see jakarta.persistence.Query#setParameter(int, Calendar, TemporalType)
293+
*
294+
* @deprecated since {@link TemporalType} is deprecated
278295
*/
296+
@Deprecated(since = "7")
279297
CommonQueryContract setParameter(int parameter, Calendar value, TemporalType temporalType);
280298

281299
/**
@@ -329,12 +347,18 @@ public interface CommonQueryContract {
329347

330348
/**
331349
* @see jakarta.persistence.Query#setParameter(Parameter, Calendar, TemporalType)
350+
*
351+
* @deprecated since {@link TemporalType} is deprecated
332352
*/
353+
@Deprecated(since = "7")
333354
CommonQueryContract setParameter(Parameter<Calendar> param, Calendar value, TemporalType temporalType);
334355

335356
/**
336357
* @see jakarta.persistence.Query#setParameter(Parameter, Date, TemporalType)
358+
*
359+
* @deprecated since {@link TemporalType} is deprecated
337360
*/
361+
@Deprecated(since = "7")
338362
CommonQueryContract setParameter(Parameter<Date> param, Date value, TemporalType temporalType);
339363

340364
/**

‎hibernate-core/src/main/java/org/hibernate/query/MutationQuery.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,13 +107,13 @@ public interface MutationQuery extends CommonQueryContract {
107107
@Override
108108
<P> MutationQuery setParameter(String name, P value, BindableType<P> type);
109109

110-
@Override
110+
@Override @Deprecated(since = "7")
111111
MutationQuery setParameter(String name, Instant value, TemporalType temporalType);
112112

113-
@Override
113+
@Override @Deprecated(since = "7")
114114
MutationQuery setParameter(String name, Calendar value, TemporalType temporalType);
115115

116-
@Override
116+
@Override @Deprecated(since = "7")
117117
MutationQuery setParameter(String name, Date value, TemporalType temporalType);
118118

119119
@Override
@@ -125,13 +125,13 @@ public interface MutationQuery extends CommonQueryContract {
125125
@Override
126126
<P> MutationQuery setParameter(int position, P value, BindableType<P> type);
127127

128-
@Override
128+
@Override @Deprecated(since = "7")
129129
MutationQuery setParameter(int position, Instant value, TemporalType temporalType);
130130

131-
@Override
131+
@Override @Deprecated(since = "7")
132132
MutationQuery setParameter(int position, Date value, TemporalType temporalType);
133133

134-
@Override
134+
@Override @Deprecated(since = "7")
135135
MutationQuery setParameter(int position, Calendar value, TemporalType temporalType);
136136

137137
@Override
@@ -146,10 +146,10 @@ public interface MutationQuery extends CommonQueryContract {
146146
@Override
147147
<T> MutationQuery setParameter(Parameter<T> param, T value);
148148

149-
@Override
149+
@Override @Deprecated(since = "7")
150150
MutationQuery setParameter(Parameter<Calendar> param, Calendar value, TemporalType temporalType);
151151

152-
@Override
152+
@Override @Deprecated(since = "7")
153153
MutationQuery setParameter(Parameter<Date> param, Date value, TemporalType temporalType);
154154

155155
@Override

‎hibernate-core/src/main/java/org/hibernate/query/NativeQuery.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -708,13 +708,13 @@ interface FetchReturn extends ResultNode {
708708
@Override
709709
<P> NativeQuery<T> setParameter(String name, P val, BindableType<P> type);
710710

711-
@Override
711+
@Override @Deprecated(since = "7")
712712
NativeQuery<T> setParameter(String name, Instant value, TemporalType temporalType);
713713

714-
@Override
714+
@Override @Deprecated(since = "7")
715715
NativeQuery<T> setParameter(String name, Calendar value, TemporalType temporalType);
716716

717-
@Override
717+
@Override @Deprecated(since = "7")
718718
NativeQuery<T> setParameter(String name, Date value, TemporalType temporalType);
719719

720720
@Override
@@ -726,13 +726,13 @@ interface FetchReturn extends ResultNode {
726726
@Override
727727
<P> NativeQuery<T> setParameter(int position, P val, BindableType<P> type);
728728

729-
@Override
729+
@Override @Deprecated(since = "7")
730730
NativeQuery<T> setParameter(int position, Instant value, TemporalType temporalType);
731731

732-
@Override
732+
@Override @Deprecated(since = "7")
733733
NativeQuery<T> setParameter(int position, Calendar value, TemporalType temporalType);
734734

735-
@Override
735+
@Override @Deprecated(since = "7")
736736
NativeQuery<T> setParameter(int position, Date value, TemporalType temporalType);
737737

738738
@Override
@@ -747,10 +747,10 @@ interface FetchReturn extends ResultNode {
747747
@Override
748748
<P> NativeQuery<T> setParameter(Parameter<P> param, P value);
749749

750-
@Override
750+
@Override @Deprecated(since = "7")
751751
NativeQuery<T> setParameter(Parameter<Calendar> param, Calendar value, TemporalType temporalType);
752752

753-
@Override
753+
@Override @Deprecated(since = "7")
754754
NativeQuery<T> setParameter(Parameter<Date> param, Date value, TemporalType temporalType);
755755

756756
@Override

‎hibernate-core/src/main/java/org/hibernate/query/Query.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -461,18 +461,19 @@ default Query<R> applyLoadGraph(@SuppressWarnings("rawtypes") RootGraph graph) {
461461
* Bind an {@link Instant} value to the named query parameter using
462462
* just the portion indicated by the given {@link TemporalType}.
463463
*/
464+
@Deprecated(since = "7")
464465
Query<R> setParameter(String parameter, Instant argument, TemporalType temporalType);
465466

466467
/**
467468
* {@link jakarta.persistence.Query} override
468469
*/
469-
@Override
470+
@Override @Deprecated(since = "7")
470471
Query<R> setParameter(String parameter, Calendar argument, TemporalType temporalType);
471472

472473
/**
473474
* {@link jakarta.persistence.Query} override
474475
*/
475-
@Override
476+
@Override @Deprecated(since = "7")
476477
Query<R> setParameter(String parameter, Date argument, TemporalType temporalType);
477478

478479

@@ -509,18 +510,19 @@ default Query<R> applyLoadGraph(@SuppressWarnings("rawtypes") RootGraph graph) {
509510
* Bind an {@link Instant} value to the ordinal query parameter using
510511
* just the portion indicated by the given {@link TemporalType}.
511512
*/
513+
@Override @Deprecated(since = "7")
512514
Query<R> setParameter(int parameter, Instant argument, TemporalType temporalType);
513515

514516
/**
515517
* {@link jakarta.persistence.Query} override
516518
*/
517-
@Override
519+
@Override @Deprecated(since = "7")
518520
Query<R> setParameter(int parameter, Date argument, TemporalType temporalType);
519521

520522
/**
521523
* {@link jakarta.persistence.Query} override
522524
*/
523-
@Override
525+
@Override @Deprecated(since = "7")
524526
Query<R> setParameter(int parameter, Calendar argument, TemporalType temporalType);
525527

526528
/**
@@ -576,13 +578,13 @@ default Query<R> applyLoadGraph(@SuppressWarnings("rawtypes") RootGraph graph) {
576578
/**
577579
* {@link jakarta.persistence.Query} override
578580
*/
579-
@Override
581+
@Override @Deprecated(since = "7")
580582
Query<R> setParameter(Parameter<Calendar> parameter, Calendar argument, TemporalType temporalType);
581583

582584
/**
583585
* {@link jakarta.persistence.Query} override
584586
*/
585-
@Override
587+
@Override @Deprecated(since = "7")
586588
Query<R> setParameter(Parameter<Date> parameter, Date argument, TemporalType temporalType);
587589

588590

0 commit comments

Comments
 (0)