Skip to content

Commit ae2a539

Browse files
committed
improv: add comments on Log Record filtering
1 parent 61cddb0 commit ae2a539

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

aws_lambda_powertools/logging/filters.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ def __init__(self, logger):
66
self.logger = logger
77

88
def filter(self, record): # noqa: A003
9-
"""Suppress Log Records from registered logger"""
10-
if self.logger in record.name:
11-
return False
12-
return True
9+
"""Suppress Log Records from registered logger
10+
11+
It rejects log records from registered logger e.g. a child logger
12+
otherwise it honours log propagation from any log record
13+
created by loggers who don't have a handler.
14+
"""
15+
logger = record.name
16+
return False if self.logger in logger else True

aws_lambda_powertools/logging/logger.py

+3
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,9 @@ def _init_logger(self, **kwargs):
159159

160160
logger.debug("Adding filter in root logger to suppress child logger records to bubble up")
161161
for handler in logging.root.handlers:
162+
# It'll add a filter to suppress any child logger from self.service
163+
# Where service is Order, it'll reject parent logger Order,
164+
# and child loggers such as Order.checkout, Order.shared
162165
handler.addFilter(SuppressFilter(self.service))
163166

164167
def _configure_sampling(self):

0 commit comments

Comments
 (0)