refactor(schema-validator): rename each Validator

Author: heitorlessa

aws_lambda_powertools/utilities/feature_flags/schema.py

@@ -33,11 +33,11 @@ def validate(self) -> None:
         if not isinstance(self.schema, dict):
             raise ConfigurationError(f"Schema must be a dictionary, schema={str(self.schema)}")
 
-        features = Features(schema=self.schema)
+        features = FeaturesValidator(schema=self.schema)
         features.validate()
 
 
-class Features(BaseValidator):
+class FeaturesValidator(BaseValidator):
     def __init__(self, schema):
         self.schema = schema
         self.features: Optional[Dict[str, Dict]] = None
@@ -51,7 +51,7 @@ def validate(self):
 
         for name, feature in self.features.items():
             self.validate_feature(name, feature)
-            rules = FeatureRules(feature=feature, feature_name=name)
+            rules = RulesValidator(feature=feature, feature_name=name)
             rules.validate()
 
     @staticmethod
@@ -64,7 +64,7 @@ def validate_feature(name, feature):
             raise ConfigurationError(f"'feature_default_value' boolean key must be present, feature_name={name}")
 
 
-class FeatureRules(BaseValidator):
+class RulesValidator(BaseValidator):
     def __init__(self, feature: Dict[str, Any], feature_name: str):
         self.feature = feature
         self.feature_name = feature_name
@@ -80,7 +80,7 @@ def validate(self):
 
         for rule in self.rules:
             self.validate_rule(rule, self.feature)
-            conditions = FeatureRuleConditions(rule=rule, rule_name=rule.get(RULE_NAME_KEY))
+            conditions = ConditionsValidator(rule=rule, rule_name=rule.get(RULE_NAME_KEY))
             conditions.validate()
 
     def validate_rule(self, rule, feature_name):
@@ -106,7 +106,7 @@ def validate_rule_default_value(rule):
             raise ConfigurationError(f"'rule_default_value' key must have be bool, rule_name={rule_name}")
 
 
-class FeatureRuleConditions(BaseValidator):
+class ConditionsValidator(BaseValidator):
     def __init__(self, rule: Dict[str, Any], rule_name: str):
         self.conditions = rule.get(CONDITIONS_KEY, {})
         self.rule_name = rule_name

tests/functional/feature_toggles/test_schema_validation.py

@@ -14,7 +14,7 @@
     RULE_DEFAULT_VALUE,
     RULE_NAME_KEY,
     RULES_KEY,
-    FeatureRules,
+    RulesValidator,
     SchemaValidator,
 )
 
@@ -327,5 +327,5 @@ def test_validate_rule_invalid_rule_name():
     # WHEN calling _validate_rule
     # THEN raise ConfigurationError
     with pytest.raises(ConfigurationError, match="'rule_name' key must be present*"):
-        rules_validator = FeatureRules(feature=feature, feature_name="my_feature")
+        rules_validator = RulesValidator(feature=feature, feature_name="my_feature")
         rules_validator.validate_rule_name(rule=rule, feature_name="my_feature")