Skip to content

Commit 1b7f248

Browse files
houbieihoubr
and
ihoubr
authored
fix(logger): exclude source_logger in copy_config_to_registered_loggers (aws-powertools#1001)
Co-authored-by: ihoubr <[email protected]>
1 parent 1eb9bb3 commit 1b7f248

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

aws_lambda_powertools/logging/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ def copy_config_to_registered_loggers(
3838
if exclude:
3939
exclude.add(source_logger.name)
4040
else:
41-
exclude = set(source_logger.name)
41+
exclude = {source_logger.name}
4242

4343
# Prepare loggers set
4444
if include:

tests/functional/test_logger_utils.py

+11
Original file line numberDiff line numberDiff line change
@@ -182,3 +182,14 @@ def test_copy_config_to_ext_loggers_custom_log_level(stdout, logger, log_level):
182182
assert logger.level == log_level.WARNING.value
183183
assert log["message"] == msg
184184
assert log["level"] == log_level.WARNING.name
185+
186+
187+
def test_copy_config_to_ext_loggers_should_not_break_append_keys(stdout, logger, log_level):
188+
# GIVEN powertools logger initialized
189+
powertools_logger = Logger(service=service_name(), level=log_level.INFO.value, stream=stdout)
190+
191+
# WHEN configuration copied from powertools logger to ALL external loggers
192+
utils.copy_config_to_registered_loggers(source_logger=powertools_logger)
193+
194+
# THEN append_keys should not raise an exception
195+
powertools_logger.append_keys(key="value")

0 commit comments

Comments
 (0)