Skip to content

Commit 94d8cc5

Browse files
grongorgrongor
authored
logging: add missing capability MoveResourceState (#432)
* logging: add missing capability MoveResourceState ---------
1 parent 11902aa commit 94d8cc5

File tree

6 files changed

+50
-0
lines changed

6 files changed

+50
-0
lines changed

‎.changes/unreleased/BUG FIXES-20240917-162414.yaml

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
kind: BUG FIXES
2+
body: 'logging: Add existing `MoveResourceState` server capability to v5 and v6 logging'
3+
time: 2024-09-17T16:24:14.06442-04:00
4+
custom:
5+
Issue: "432"

‎internal/logging/keys.go

+3
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ const (
6969
// Whether the GetProviderSchemaOptional server capability is enabled
7070
KeyServerCapabilityGetProviderSchemaOptional = "tf_server_capability_get_provider_schema_optional"
7171

72+
// Whether the MoveResourceState server capability is enabled
73+
KeyServerCapabilityMoveResourceState = "tf_server_capability_move_resource_state"
74+
7275
// Whether the PlanDestroy server capability is enabled
7376
KeyServerCapabilityPlanDestroy = "tf_server_capability_plan_destroy"
7477

‎tfprotov5/internal/tf5serverlogging/server_capabilities.go

+2
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ import (
1414
func ServerCapabilities(ctx context.Context, capabilities *tfprotov5.ServerCapabilities) {
1515
responseFields := map[string]interface{}{
1616
logging.KeyServerCapabilityGetProviderSchemaOptional: false,
17+
logging.KeyServerCapabilityMoveResourceState: false,
1718
logging.KeyServerCapabilityPlanDestroy: false,
1819
}
1920

2021
if capabilities != nil {
2122
responseFields[logging.KeyServerCapabilityGetProviderSchemaOptional] = capabilities.GetProviderSchemaOptional
23+
responseFields[logging.KeyServerCapabilityMoveResourceState] = capabilities.MoveResourceState
2224
responseFields[logging.KeyServerCapabilityPlanDestroy] = capabilities.PlanDestroy
2325
}
2426

‎tfprotov5/internal/tf5serverlogging/server_capabilities_test.go

+19
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ func TestServerCapabilities(t *testing.T) {
3131
"@message": "Announced server capabilities",
3232
"@module": "sdk.proto",
3333
"tf_server_capability_get_provider_schema_optional": false,
34+
"tf_server_capability_move_resource_state": false,
3435
"tf_server_capability_plan_destroy": false,
3536
},
3637
},
@@ -43,6 +44,7 @@ func TestServerCapabilities(t *testing.T) {
4344
"@message": "Announced server capabilities",
4445
"@module": "sdk.proto",
4546
"tf_server_capability_get_provider_schema_optional": false,
47+
"tf_server_capability_move_resource_state": false,
4648
"tf_server_capability_plan_destroy": false,
4749
},
4850
},
@@ -57,6 +59,22 @@ func TestServerCapabilities(t *testing.T) {
5759
"@message": "Announced server capabilities",
5860
"@module": "sdk.proto",
5961
"tf_server_capability_get_provider_schema_optional": true,
62+
"tf_server_capability_move_resource_state": false,
63+
"tf_server_capability_plan_destroy": false,
64+
},
65+
},
66+
},
67+
"move_resource_state": {
68+
capabilities: &tfprotov5.ServerCapabilities{
69+
MoveResourceState: true,
70+
},
71+
expected: []map[string]interface{}{
72+
{
73+
"@level": "trace",
74+
"@message": "Announced server capabilities",
75+
"@module": "sdk.proto",
76+
"tf_server_capability_get_provider_schema_optional": false,
77+
"tf_server_capability_move_resource_state": true,
6078
"tf_server_capability_plan_destroy": false,
6179
},
6280
},
@@ -71,6 +89,7 @@ func TestServerCapabilities(t *testing.T) {
7189
"@message": "Announced server capabilities",
7290
"@module": "sdk.proto",
7391
"tf_server_capability_get_provider_schema_optional": false,
92+
"tf_server_capability_move_resource_state": false,
7493
"tf_server_capability_plan_destroy": true,
7594
},
7695
},

‎tfprotov6/internal/tf6serverlogging/server_capabilities.go

+2
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ import (
1414
func ServerCapabilities(ctx context.Context, capabilities *tfprotov6.ServerCapabilities) {
1515
responseFields := map[string]interface{}{
1616
logging.KeyServerCapabilityGetProviderSchemaOptional: false,
17+
logging.KeyServerCapabilityMoveResourceState: false,
1718
logging.KeyServerCapabilityPlanDestroy: false,
1819
}
1920

2021
if capabilities != nil {
2122
responseFields[logging.KeyServerCapabilityGetProviderSchemaOptional] = capabilities.GetProviderSchemaOptional
23+
responseFields[logging.KeyServerCapabilityMoveResourceState] = capabilities.MoveResourceState
2224
responseFields[logging.KeyServerCapabilityPlanDestroy] = capabilities.PlanDestroy
2325
}
2426

‎tfprotov6/internal/tf6serverlogging/server_capabilities_test.go

+19
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ func TestServerCapabilities(t *testing.T) {
3131
"@message": "Announced server capabilities",
3232
"@module": "sdk.proto",
3333
"tf_server_capability_get_provider_schema_optional": false,
34+
"tf_server_capability_move_resource_state": false,
3435
"tf_server_capability_plan_destroy": false,
3536
},
3637
},
@@ -43,6 +44,7 @@ func TestServerCapabilities(t *testing.T) {
4344
"@message": "Announced server capabilities",
4445
"@module": "sdk.proto",
4546
"tf_server_capability_get_provider_schema_optional": false,
47+
"tf_server_capability_move_resource_state": false,
4648
"tf_server_capability_plan_destroy": false,
4749
},
4850
},
@@ -57,6 +59,22 @@ func TestServerCapabilities(t *testing.T) {
5759
"@message": "Announced server capabilities",
5860
"@module": "sdk.proto",
5961
"tf_server_capability_get_provider_schema_optional": true,
62+
"tf_server_capability_move_resource_state": false,
63+
"tf_server_capability_plan_destroy": false,
64+
},
65+
},
66+
},
67+
"move_resource_state": {
68+
capabilities: &tfprotov6.ServerCapabilities{
69+
MoveResourceState: true,
70+
},
71+
expected: []map[string]interface{}{
72+
{
73+
"@level": "trace",
74+
"@message": "Announced server capabilities",
75+
"@module": "sdk.proto",
76+
"tf_server_capability_get_provider_schema_optional": false,
77+
"tf_server_capability_move_resource_state": true,
6078
"tf_server_capability_plan_destroy": false,
6179
},
6280
},
@@ -71,6 +89,7 @@ func TestServerCapabilities(t *testing.T) {
7189
"@message": "Announced server capabilities",
7290
"@module": "sdk.proto",
7391
"tf_server_capability_get_provider_schema_optional": false,
92+
"tf_server_capability_move_resource_state": false,
7493
"tf_server_capability_plan_destroy": true,
7594
},
7695
},

0 commit comments

Comments
 (0)